Giter Club home page Giter Club logo

Comments (3)

GeekMin avatar GeekMin commented on May 28, 2024

what I think is like this:
I can give the tool some knowledge:
TextUtils.isEmpty(arg) <-> if (arg == null)
!TextUtils.isEmpty(arg) <-> if (arg != null)

from spotbugs.

jsotuyod avatar jsotuyod commented on May 28, 2024

Hi! I'm a little bit confused as to your report. I'm not sure what bug description you refer to by "is_null_checked". Can you please state exactly the bug being reported by Findbugs / Spotbugs?

As you say, Android's TextUtils.isEmpty return true for both null and empty string. Therefore, a code such as:

String uin = null;
if (android.text.TextUtils.isEmpty(uin)) {
    uin.length(); // This produces a Null Pointer Exception!
}

As such, if it is reporting a null pointer dereference, then the behavior is actually correct.

Could you please clarify? Thanks in advanced

from spotbugs.

GeekMin avatar GeekMin commented on May 28, 2024
class TestTextUtils {
  public void foo(String uin){
    if (android.text.TextUtils.isEmpty(uin)){
        System.out.println("do nothing");
        uin.length();  // expected warning here
    } else {
        uin.length();
    }
  }
    
  static boolean isEmpty(String uin){
    if (uin == null || uin.length()==0)
        return true;
    else
        return false;
        
  }
  public void bar(String uin){
    if (isEmpty(uin)){
        System.out.println("do nothing");
        uin.length();   // expected warning here
    } else {
        uin.length();
    }
    
  }
}

sorry, previous example is not that correct.. you can refer to below code..
Checking this code, Findbugs doesn't find anything..

from spotbugs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.