Comments (13)
@Vogel612 if the issue is indeed with #2894 I think that the improvement in the PR is not worth the regressions reported here?
Would you be able to look into it? Otherwise I agree with @esabol that reverting it might be reasonable
from spotbugs.
assuming generating an XML report withMessages also works as intended...
When I diff SpotBugs XML output between 4.8.2 and 4.8.5, having set output to xml:withMessages
, the shortMessage and longMessage blocks are missing from the bugInstance.
< <ShortMessage>Redundant nullcheck of value known to be non-null</ShortMessage>
< <LongMessage>Redundant nullcheck of maxuptime, which is known to be non-null in new com.example.Test(boolean, String[])</LongMessage>
Additionally, the <SourceLine>
blocks, <LocalVariable>
, etc blocks are self-closing instead of including a <Message>
.
from spotbugs.
I checked out the source for SpotBugs and on commit 6cf7b2c I did "git revert 789d397" and rebuilt the jar locally. The locally built jar appears to work correctly in this scenario.
from spotbugs.
Thanks, everyone!
from spotbugs.
Hello @Vogel612, I'm not sure how this was working but I was wondering if this could be a side effect of #2894
from spotbugs.
Maybe it can be because of #2915. Can you please share the fancy-hist.xml
? Is there any error logged about this?
from spotbugs.
I think the xsl is part of SpotBugs: https://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/xsl/fancy-hist.xsl
I was wondering about the version change for the filter xsd too, that might be the problem
from spotbugs.
Yes, the fancy-host.xsl
we are using is the one provided by SpotBugs, as @gtoison indicated. We haven't modified it or moved it.
I'm not seeing any error messages. Where would they be logged to in this scenario?
from spotbugs.
My colleague additionally tested it with SpotBugs 4.8.2, and the stylesheet worked.
Also tested 4.8.4 with stylesheet="${spotbugs.home}/src/xsl/fancy-hist.xsl"
instead of stylesheet="fancy-hist.xsl"
. Still didn't work.
4.8.3 works with either of those two stylesheet
attribute values.
from spotbugs.
Hello @Vogel612, I'm not sure how this was working but I was wondering if this could be a side effect of #2894
The changeset you mention should only affect the filepaths, although I did touch the stylesheet assignment so I can't exclude it with any degree of certainty. Judging by the syntax of the options, the code contributed with that changeset should be working as intended and not mess with the stylesheets, assuming generating an XML report withMessages
also works as intended...
I haven't checked the release yet, but unfortunately this seems like my changes are a more likely culprit than the filter XSD namespace changes...
from spotbugs.
Is there a developer who can look into this? Maybe try reverting PR #2894?
from spotbugs.
@gtoison I really don't have the capacity to look into it right now. I'm happy to go for a revert, the improvement is only marginal and the regression is quite a heavy thing.
I might be able to look at it at some later point with some more test coverage around this specific element of it, but not in any reasonable time frame. I would like to see the original issue that was supposed to be fixed by that PR reopened if we revert, though :)
from spotbugs.
Closing as fixed on master, will be released in 4.9.0 as code reverted.
from spotbugs.
Related Issues (20)
- FP SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR for record HOT 5
- CT_CONSTRUCTOR_THROW: report violation for final fields HOT 2
- Another false positive SING_SINGLETON_IMPLEMENTS_SERIALIZABLE when class is not a singleton (e.g. protobuf) HOT 1
- Array index out of bounds exception on `FindDeadLocalStores` HOT 8
- Index out of bounds for empty switch HOT 3
- spotbugs-4.8.5.zip contains duplicate log4j-core-xxx.jar HOT 1
- False positive with XXE_SCHEMA_FACTORY (and possibly similar rules) when setting properties in separate method HOT 2
- False positive EI_EXPOSE_REP when copyOf or Collections::unmodifiable* is used with Java Record and Optional HOT 3
- False positive EI_EXPOSE_REP when use Collections.emptySet, emptyList or emptyMap is used
- Disable output during Maven goal `spotbugs:check` as redundant with site generation HOT 4
- Asked to end timing for class X but top of stack is class Y remaining stack is [edu.umd.cs.findbugs.log.Profiler HOT 3
- false positive SING_SINGLETON_GETTER_NOT_SYNCHRONIZED with synchronized initialization-method HOT 3
- Facing issues using spotbugs plugin 6.0.19 with Java 17 HOT 3
- Issue during analysis of SpringCGLIB after Spring Boot Native build HOT 13
- Here's a sample code snippet to check if a given string matches a date format HOT 2
- False positive NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE when using Nullable annotations with TYPE_USE
- missing close() call not reported in certain cases HOT 6
- Lombok @Getter(lazy = true) causes JLM_JSR166_UTILCONCURRENT_MONITORENTER + RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE HOT 7
- Irrelevant `NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR` for Kotlin data classes HOT 3
- The MacOS builds fail HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spotbugs.