sporkwitch / autokey Goto Github PK

I went ahead and forged a new release (0.95.0) in the upstream repository.

• I fiddled a bit with the dependencies in the control file. (This will cause you merge conflicts, sorry about that!)

• I think, you added a bit too much to the build dependencies:
  

  autokey/debian/control

  Lines 6 to 17 in 7f18355

  	Build-Depends:
  	python3-all,
  	python3-setuptools,
  	python3-dbus,
  	python3-xlib,
  	python3-gi,
  	gir1.2-gtk-3.0,
  	dh-python,
  	debhelper,
  	pyqt5-dev-tools,
  	python3-pyqt5.qsci,
  	python3-pyqt5.qtsvg

  
  This is definitely correct for projects written in a compiled language, like C++, because the libraries need to be present during the binary linking step. But since this is a pure Python project, almost all dependencies are pure runtime dependencies.
  I decoupled setup.py and the autokey package here (autokey@4d77b50), thus the runtime dependencies should not be needed during the package build. (Because no autokey code is executed, thus the imports are not run.)

• You are manually adjusting the dependencies in the debian/control file each time you push a new release. I found a nice option that completely obsoletes fiddling with the Replaces specification.
  You can use ${binary:Version} to refer to the exact version of the currently built package.
  Thus you can just specify that e.g. autokey-common Replaces: autokey-common (<< ${binary:Version}) and be done with it. If currently built version is X.Y.Z, then the package will automatically replace everything <X.Y.Z.

• You changed the versions in Replaces: autokey (<<0.61.4-0~0). As far as I know, the split into three packages (-common, -qt, -gtk) occurred after 0.61.4, so those were originally meant to ensure that ancient package versions get replaced. Well, bumping it should not cause issues, because even autokey (<< 100.0.0) would also match those. Just there is no package called exactly autokey any more.
  In the upstream repo, I added a replacement dependency to each package, causing each to replace their older versions: (This takes care of the bullet point above)
  

  autokey/debian/control

  Line 28 in 7dfc02c

  Replaces: autokey (<<0.61.4-0~0), autokey-common (<<${binary:Version})

  
  

  autokey/debian/control

  Line 54 in 7dfc02c

  Replaces: autokey (<<0.61.4-0~0), autokey-gtk (<<${binary:Version})

  
  

  autokey/debian/control

  Line 77 in 7dfc02c

  Replaces: autokey (<<0.61.4-0~0), autokey-qt (<< ${binary:Version})