Giter Club home page Giter Club logo

vault-plugin-secrets-artifactory's Introduction

Splunk OCSF Extension

The Splunk schema extension repository

vault-plugin-secrets-artifactory's People

Contributors

dependabot[bot] avatar m0rosan avatar nickshine avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

vault-plugin-secrets-artifactory's Issues

Role deletion can leave dangling groups on artifactory

The vault storage entry is removed before cleaning up artifactory resources

if err := backend.deleteRoleEntry(ctx, req.Storage, roleName); err != nil {
return logical.ErrorResponse(fmt.Sprintf("Unable to remove role %s", roleName)), err
}
// Try to clean up resources.
if cleanupErr := backend.tryDeleteRoleResources(ctx, req, role, role.PermissionTargets, 0, deleteGroup); cleanupErr != nil {
backend.Logger().Warn(
"unable to clean up unused artifactory resources from deleted role.",
"role_name", roleName, "errors", cleanupErr)
return &logical.Response{Warnings: []string{cleanupErr.Error()}}, nil
}
backend.Logger().Debug("successfully deleted role and artifactory resources", "name", roleName)

Artifactory cleanup should happen before deleting entries from vault storage.

If a resource on artifactory cannot be deleted due to well known pre-reqs not met (eg: missing role after external deletion), the role deletion should succeed.

Additionally, a force/skip option can be accepted on deletion to delete vault storage entries regardless of the outcome of the artifactory calls.

additional group settings for a token

it's currently creating a token scoped to a group with given permission targets.
we should have a capability to let a token scoped to multiple groups.

this is beneficial when it comes to sharing a common group. i.e. reader group or metadata write permission.

AC:

  • role accepts groups parameter which accepts existing groups
  • token is created against a created group and groups

validation:

  • it's possible to only pass groups but not permission targets at the time of role creation and it shouldn't error out

TBD:
non-existing group is attached to a role. it'll for sure throw out run time error at the time of token creation. should we also have a group existence check at the time of role creation?

Setup CI

setting up CI

  • CLA check
  • test
  • code coverage
  • security scanning
  • package build/publish

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.