splittingred / breadcrumbs Goto Github PK

I am not at all fond of these new scheme.org specs as they throws a heap of validation errors (as it is not a part of any standard spec yet).
It could at least be optional (e.g. &useSchemaOrgAttribs=1) or something. Don't force us to all have invalid code everywhere that breadcrumbs lie. It also bloats out the html as well.

BreadCrumbs add an extra

When pathThruUnPub = 0 and U try to open unpublish page , U will get error.
Fatal error: Uncaught Error: Call to a member function get() on null in core/components/breadcrumbs/model/breadcrumbs/breadcrumbs.class.php:170 Stack trace: #0 core/components/breadcrumbs/model/breadcrumbs/breadcrumbs.class.php(266): BreadCrumbs->showCurrentPage(37) #1 core/cache/includes/elements/modsnippet/2.include.cache.php(55): BreadCrumbs->run() #2 core/model/modx/modscript.class.php(70): include('/www...') #3 core/model/modx/modparser.class.php(536): modScript->process() #4 core/components/pdotools/model/pdotools/pdoparser.class.php(273): modParser->processTag(Array, false) #5 core/model/modx/modparser.class.php(250): pdoParser->processTag(Array, false) #6 core/components/pdotools/model/pdotools/pdoparser.class.php(64): modParser->processElementTags('[[$breadcrumbs]...', '
Modx 2.7, 2.6.5
U can see this error only if U are logged in Manager

This component should accept a external template (chunk) set in paramters.

Since last week Google Search Console has been reporting on errors in the Breadcrumb "data-vocabulary.org schema deprecated", you can find more information here https://webmasters.googleblog.com/2020/01/data-vocabulary.html

Google Search Console recommended use schema https://schema.org/BreadcrumbList

Modify file core/components/breadcrumbs/model/breadcrumbs/breadcrumbs.class.php from line 149 to 157.

Would like to see a more templatable way of the the crumb parts.

What I do is very simple;
Modify the breadcrumbs class inside the model directory and add these lines below the $this->_tpls = array(); definition

/* parse tpl names into _tpls array */
foreach($this->config as $key => $value) {
    if(substr($key, 0, 10) == 'bcTplCrumb') {
        $this->_tpls[$key] = $value;
    }
}

Now you can add properties with the tpl name and override the templates within the breadcrumb. Other possibility is also fine by me but this works great and is easy to apply