spitty / miptshows Goto Github PK

Typical modifiers for the constant is:
private static final

If you omit "static" then new variable will be created for every new instance 
of your class.

The most part of methods in JcifsController class is redundant and can be 
removed.

It is very necessary to finish this class and to provide another one to operate 
with prepared statements on inserting data in the DB.

Check if there is no oppotunity to replace List with more common Collection 
interface.

Containing all classes in the only package is a very bad practice.
Classes should be union by its place in logical structure of the program

Code always must be self-documented. It means than names of classes, fields, 
methods and variables must contain general description of the item.

Firstly, when you calculate string 
"MERGE"
+ "INTO files f"
+ "USING temp_data td"
+ "ON (td.file_name = f.file_name)"
+ "WHEN NOT MATCH THEN"
    + "INSERT"
        + "(f.file_id, f.file_name, f.file_size)"
    + "VALUES"
        + "(file_id_generator.nextval, td.file_name, td.file_size)"
you obtain "MERGEINTO files fUSING temp_data tdON (td.file_name = 
f.file_name)WHEN NOT MATCH THENINSERT(f.file_id, f.file_name, 
f.file_size)VALUES(file_id_generator.nextval, td.file_name, td.file_size)".
You can notice that some words are not divided with spaces.

Second advice is to use (SELECT distinct file_name, file_size) as source table 
for merge and join not only by file_name.

Also for executing MERGEs you must use method executeUpdate (not just execute) 
of class Statement.

It will be better to extract the part interacting with MyShows in a different 
class.
Do not overload a class with complicated logic.

We need to remove redundant items from the trunk directory. 
Also the directory 'build' must be removed. 
Libraries needed for the project must be put in the directory 'java/lib'.

System.out.println must be forgotten!

Next documents must be added for this component:
1. Program overview
2. Database model
3. Installation notes
4. Functionality of the program

packages "beanpackage" and "testing" may be used in many other projects. To 
prevent misunderstooding use packages staring with "org.ncmipt.miptshows" or 
something like this.

Returning null value is a bad style.
For the caller an empty collection is more convinient.

Introduce interface to processing data obtaining by JCIFS.

We need to build installation archive with an ant script.
Installation archive must include
  project jar/war build file,
  documents (e.g. Installation Notes),
  resources (e.g. configuration files)

The package "testing" is a good tendency.
Also we need oppotunity to test the part working with MyShows API. One should 
create an emulator of api.myshows.ru