Giter Club home page Giter Club logo

Comments (12)

drcmda avatar drcmda commented on June 5, 2024 55

I would propose moving this library to https://github.com/pmndrs @RenaudRohlinger is a member but the point of it is that critical libraries can be maintained as a collective. We have helped multiple libs already that otherwise would have been abandoned like https://github.com/pmndrs/cannon-es or https://github.com/pmndrs/detect-gpu

The author remains, it's still yours @spite but we take liberty in maintaining, inviting more devs to join as well as keeping it up to date with tooling, types and so on. this way something so useful like meshline doesn't outdate as long as people are relying on it and have a vested interest in keeping it alive.

from three.meshline.

robksawyer avatar robksawyer commented on June 5, 2024 12

@spite can we move it to https://github.com/pmndrs?

from three.meshline.

RenaudRohlinger avatar RenaudRohlinger commented on June 5, 2024 9

https://github.com/utsuboco/THREE.MeshLine
I made a new version of a library using vite and typescript.

Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.

see #139 (comment)

Demo:
https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx

from three.meshline.

bryantcodesart avatar bryantcodesart commented on June 5, 2024 3

https://github.com/utsuboco/THREE.MeshLine I made a new version of a library using vite and typescript.

Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.

see #139 (comment)

Demo: https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx

For those that come later, after trying many forks/permutations to get MeshLine working with the latest three/react-three-fiber/drei stack (at time of writing) and typescript, @RenaudRohlinger version worked for me.

Note that there are some critical changes from the original r3f Fatline demo code, base your code off the example given in the quoted reply and/or the forked repo README--NOT off the original r3f demo! (I burned an hour to a bug caused by not noticing this.) In particular, vertices is switched for points.

The components will give TS errors about not being on JSX.IntrinsicElements. To fix and make full use of the awesome TS support in this fork, this worked for me:

import {
  extend, ReactThreeFiber,
} from '@react-three/fiber';
import { MeshLine, MeshLineMaterial, MeshLineRaycast } from 'meshline';

extend({ MeshLine, MeshLineMaterial });

/* eslint-disable no-unused-vars */
declare global {
  namespace JSX {
    interface IntrinsicElements {
      'meshLine': ReactThreeFiber.Object3DNode<MeshLine, typeof MeshLine>;
      'meshLineMaterial': ReactThreeFiber.Object3DNode<MeshLineMaterial, typeof MeshLineMaterial>;
    }
  }
}
/* eslint-enable no-unused-vars */

Which owes credit to: pmndrs/react-three-fiber#130 (comment)

HUGE THANK YOU TO THIS LIB AND TO RenaudRohlinger. Happy lining!

from three.meshline.

drcmda avatar drcmda commented on June 5, 2024 3

@spite @bryantcodesart @robksawyer

@RenaudRohlinger has agreed to move it over to pmndrs https://github.com/pmndrs/THREE.MeshLine this way more devs will be able to maintain and merge prs.

i've opted to make some slight breaking changes and release a major: pmndrs#4

examples are still open, it seems the demos that were in the repo don't work any longer #154 if i find time i can try to fix them up.

from three.meshline.

eulertour avatar eulertour commented on June 5, 2024 1

Is it intentional that the pmndrs repo has issues disabled?

from three.meshline.

tiye avatar tiye commented on June 5, 2024

I guess the author might want to deprecate this project. I sent links to him on Twitter twice, both ignored. while he is definitely active on Twitter and on GitHub. Just sad he didn't assign another maintainer for this project.

from three.meshline.

spite avatar spite commented on June 5, 2024

There is another maintainer. @jiyinyiyong do you want to be a maintainer?

from three.meshline.

tiye avatar tiye commented on June 5, 2024

sorry I got too many projects... how about @RenaudRohlinger ?

from three.meshline.

tiye avatar tiye commented on June 5, 2024

@spite I have some time now. guess I could help migrating this lib to ES Modules.

forked my own version of the package... https://github.com/Quatrefoil-GL/meshline .

from three.meshline.

alexander-macleod avatar alexander-macleod commented on June 5, 2024

any updates on this?

from three.meshline.

robksawyer avatar robksawyer commented on June 5, 2024

Awesome! Thanks for following up.

from three.meshline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.