Giter Club home page Giter Club logo

firefox-nativedark's People

Contributors

baranpirincal avatar gitubhu avatar spikespaz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

firefox-nativedark's Issues

Tab bar doesn't follow color scheme

All other parts seem to follow accent, just not tab bar. How do I fix this? This seems to be an error on my part but the stylesheets seem to be correct.
Edit:imgur

Incorrect color on selected tab lines (FF>=60)

The color of the line of the active tab is darker than the specified highlight color in the options page.

I don't know why this bug exists, but I think I must have forgotten to separate the unfocused and focused code for this particular style.

Here is an example, the Nightly on the left side of this tab, and the Stable version with userChrome.css on the right, cropped together.

Cropped Tabs Screenshot

Logo proposal for firefox-nativedark

Hey, I am graphic designer and my aim is make my portfolio better with supporting open source project in field of graphic. I can contribute on your project with making a logo design. I would be very pleased if you interested. I can show my portfolio if you want it. I am waiting your feedback, have a nice day! :)

Best Regards,
Baran Pirincal
Visual Communication Designer

New tab page light theme

The new tab-/start-page uses light theme of firefox, although dark theme in firefox settings is selected. When starting firefox the startpage with dark theme is shown for a second, then when native dark addon has been loaded it changes to light. Please add an option to change this, as new tab page is one of the most frequently shown contents while using firefox. Or at least change the default theme to dark, as the addon is even called native "dark".

Appart from that thx for this great addon, its one of the most important design customization on my machine, keep up the good work!

screenshot 2

A few problems with toggling 'enable adaptive'

  1. Sometimes (always?), after toggling 'enable adaptive' (i.e. changing it to one state and then to the other), the extension's icon appears in the icon bar, even when previously I had removed it.

  2. Sometimes, after altering the 'enable adaptive' setting and restarting, the new setting is lost.

  3. When one disables and then re-enables 'enable adaptive', the chosen - non-adaptive - is reset. Still, that might be by design.

Windows 8.1. Native Dark 1.6. EDIT: Firefox 63.0 (x64).

Add ability to disable transition

The transition/animation when the window becomes focused and unfocused is slower to update than the Windows title bar. For consistency, can there be an option to disable the transition?

2018-04-28_20-54-30

Support for MacOS

As silly as it may sound, I think this would look very pleasing on MacOS.

Happily, 'This is really only meant to work in Windows 10' is somewhat inaccurate

The github landing page says, 'This is really only meant to work in Windows 10'. However, on my Windows 8.1 system, and despite the horrible limitations Microsoft imposed on Windows 8 theming, your extension enables me to set the colour of that part of the Firefox title bar that is unoccupied by tabs. That allows a proper dark theme - thus:

image

Admittedly, the actual window buttons remained themed by the crippled inbuilt windows engine, but, nevertheless: bravo, and thank you.

Not immediately reflecting Windows accent color changes

I have a slideshow background (in windows) that changes accent colour every 1 minute making this extension very cool.
However, when the accent changes, i need to click outside the window and back in again to refresh.
An autorefresh therefore would be quite usefull.
Thanks

Default themes not working correctly in Nightly after removing extension

I installed this extension. However, after disable it (or even removing) I cannot get the default themes to work correctly in Nightly. Disabling/removing works as expected in Firefox.

After disabling/removing the extension from Nightly the title bar keeps the accent color incorrectly when browser window is focused. However, it has the correct theme colors when browser loses focus. See screenshots below of the Firefox Dark Theme. Again, I want to emphasize that Firefox does not have the same issue.

  • When browser window has focus:
    image

  • When browser window does not have focus:
    image

Nightly version 65.0a1
Firefox version 63.0.3

Custom active line color

Great concept, finally is possible make the perfect theme for Firefox.

Here some suggestions:

  1. In my opinion the active tab and toolbars color must be lighter than inactive tab, now is the contrary;
  2. Add the option for bold text in active tab;
  3. Add the option for add a custom top horizontal line color for active tab (will be great also for unread and unloaded tabs);
  4. The toolbar difference must be able to darken but also increase the brightness of active tab and toolbars.
  5. Add the custom color for inactive tabs (now the static color change all the theme).

You can see my idea with personal userchrome.css:
concept
The red line tab is unloaded, the yellow line tab is unread, the cyan tab line is the active tab (bold text) and the last inactive tab is without color line.
The active tab and toolbar is more light than the inactive tab for that is more readable for the eye.

Thanks.

Theme not updated when desktop background changes

From a review by Mark, a month ago:

There is one issue for me though and that is the only time the browser actually changes it's color is if I minimize it and then restore it. I have my Windows settings set that the background changes every ten minutes or so but the browser colors do not change along with it.

Add "reset to default" button on each option

The location where default values are set will need to change to a separate file, to support maintainability.

A minimal API for storage and options handling should be created as well, to prevent confusion and disorder in the markup and scripting.

Add dark theme to UI / toolbar popups

Add dark theme or styles defined in options to interface popups such as site information or add bookmark.

Coming in release v1.5, suggested by Phantom_RAM_ in a review.

Perhaps adjust to colors on website??

So, I'm often on Github and I like the default shade of black offered by this extension, but I am not able to distinguish the header of my website, and the header of my browser.

Perhaps distinguish the top of browser and the header of websites could help?

Example of what I'm facing.
screen shot 2018-02-20 at 6 42 32 pm

Even though this enhancment may sound silly, I'm sure this is an issue users will face as this extension gets used by more people.

Transparent Menu

I have installed the extension but now all the menus are transparent like in the pic

Color input won't allow me to use "-moz-win-accentcolor"

it looks like the input box is limited to 7 chars, which is the exact char count for a custom hex color code including the hash (#). I want to use whatever Windows accent color I currently set for the highlight color (the -moz-win-accentcolor 'var').

Suggestion: Either remove the character limit or add an option to use native Windows accent color for highlight color

Color extension icons to match theme

Sorry if this is out of scope or impossible, but do you think it would be possible to theme the icon for uBlock Origin to match the other white icons?

Disable text shadow?

More of a question, how to disable dark shadow behind text in tabs and url bar?

Option to change overlay colors

Currently, all overlays over accentcolor (masks) are calculated with pure black, and a user-defined opacity level.

This proposes to add an option to the options page that allows the user to choose either white, or black as the mask base color.

No other color options will be provided, as such would be considered out-of-scope for this project.

"Enable Adaptive" option not updating in time with changes

When toggling the Enable Adaptive option in the options page, the browser theme does not update with the changes / does not update the view as the option is bring clicked.

This is a bug within the browser, as the form elements #accent-color and #enable-adaptive use the same form name accentColor. When the value of the checkbox changes, the value from the FormData() object should reflect the value of the #accent-color property. However, it appears that the browser is not including this value in the FormData() object until the accent color is updated.

This thesis is supported by the following debug output, that is printed to console after each form update.

Object { toolbarOpacity: "25", omnibarOpacity: "50", highlightColor: "#0078d7", unfocusedTheme: "fade", highlightBorders: false, bottomSeparator: false }  options.js:36:5
Object { accentColor: "-moz-win-accentcolor", toolbarOpacity: "25", omnibarOpacity: "50", highlightColor: "#0078d7", unfocusedTheme: "fade", highlightBorders: false, bottomSeparator: false }  options.js:36:5
Object { toolbarOpacity: "25", omnibarOpacity: "50", highlightColor: "#0078d7", unfocusedTheme: "fade", highlightBorders: false, bottomSeparator: false }  options.js:36:5

Add support for Places

The Places/Library window (chrome://browser/content/places/places.xul) is not styled by the extension.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.