spesmilo / electrum-web Goto Github PK

Some links to pages formerly loaded by javascript have been broken by #20:
For example, https://electrum.org/#privacy (required by Google Play) is no longer reachable.

List of broken links:

• The "about" page (https://electrum.org/#about) contains a link to Thomas Voegtlin's gpg key located at http://keys.gnupg.net/pks/lookup?search=0x6694D8DE7BE8EE5631BED9502BD5824B7F9470E6&fingerprint=on&op=index
• The "download" page (https://electrum.org/#download) contains links to
  • Windows Tutorial https://bitzuma.com/posts/how-to-verify-an-electrum-download-on-windows/
  • macOS Tutorial https://bitzuma.com/posts/how-to-verify-an-electrum-download-on-mac/

I couldn't find fee setting in new android version. where is it!?

In the section, "How to verify GPG signatures", there is the following:

In order to be able to verify GPG signatures, you need to import the public key of the signer. Electrum binaries are signed with ThomasV's public key. On Linux, you can import that key using the following command: gpg --import ThomasV.asc.

This is a little unclear. Someone who doesn't know how to use GnuPG might not realize that "ThomasV.asc" is just a placeholder for however they input the key, as this Reddit post demonstrates. I suggest rewriting it to make it clearer. Also, watch the order of instructions, as it appears to ask them to verify the signature before importing the key.

The html files cannot be easily tested in a browser locally.
The website is broken when using the file:// protocol; it works when using http://,
so the workaround is to run a webserver locally.

Firefox (87.0) logs:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at file:///.../electrum-web/panel-download.html. (Reason: CORS request not http).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at file:///.../electrum-web/projects.json. (Reason: CORS request not http).

See https://developer.mozilla.org/en-US/docs/Archive/Misc_top_level/Same-origin_policy_for_file:_URIs

The website currently requires javascript to function.
Notably, the panel-switching and the "slide-show" (on Home) use js.

At least the panel-switching should not rely on js, to make the site usable without js.

Notably, Tor Browser on some configurations has javascript disabled by default.

Workaround for users for now:

• either enable javascript just for electrum.org (perhaps temporarily), or
• re updates/downloads, go directly to download.electrum.org

Removing javascript would be a lot easier if all the panel/subpages were in a single html file.
This site shows how to do the panel-switching without js: https://dev.to/hakash/100-pure-htmlcss-page-navigation---no-javascript-required-2em5

Note that there's this script that generates the download html page: https://github.com/spesmilo/electrum/blob/84ca7ef3060cc00e87fb41a18038d66c008a5624/contrib/make_download - which should be adapted or keep working as is

Can someone provide me with the new svg version of the electrum icon?

I found the png version. But the svg version seems outdated.

Is it safe to assume that https://www.get-electrum.com is not a valid website? Had a client of mine bring it to my attention because they were not sure where to download the app from.

I think it's great that you're sharing the source code for the website. It would be good to have a license on it (maybe MIT like the electrum project itself) so that people can use proper open source JavaScript to easily download electrum.