Comments (2)
This problem seems to stem from several places. Firstly, the criteria merger should not continue merging operations after encountering an anonymous lambda. At its current state, it merges any operations that contain a JPAStreamer predicate, regardless of the ordering in the pipeline.
After fixing that, a similar test still fails:
try (StreamSupplier<Film> supplier = jpaStreamer.createStreamSupplier(Film.class)) {
final List<String> actual = supplier.stream()
.filter(f -> f.getLength() > 120)
.sorted(Film$.length)
.filter(Film$.title.startsWith("A"))
.map(Film$.title)
.limit(10)
.collect(Collectors.toList());
final List<String> expected = supplier.stream()
.filter(f -> f.getLength() > 120)
.sorted(Comparator.comparing(Film::getLength))
.map(Film::getTitle)
.filter(title -> title.startsWith("A"))
.limit(10)
.collect(Collectors.toList());
assertEquals(expected, actual);
}
In this case, reordering rules allow the first Stream to be optimized as:
final List<String> actual = supplier.stream()
.sorted(Film$.length)
.filter(Film$.title.startsWith("A"))
.filter(f -> f.getLength() > 120)
.map(Film$.title)
.limit(10)
.collect(Collectors.toList());
This means we can merge the sort and the filter on the title into the query without any issues. However, the limit is also applied on the DB side, limiting the results to 10 before the filter length > 120 is executed. Due to the sorting operation, the 10 shortest films are returned and none of them will match the criteria length > 120.
from jpa-streamer.
Another example is this test:
final List<String> actual = supplier.stream()
.filter(Film$.title.startsWith("A"))
.skip(10)
.filter(f -> f.getLength() > 120)
.sorted(Film$.length)
.limit(10)
.map(Film$.title)
.collect(Collectors.toList());
Here the SORTED is merged even though the SKIP precedes it. As SQL always applies SKIPS and LIMITS to the end of all other operations, we cannot merge this sort as it will change what entities are skipped.
from jpa-streamer.
Related Issues (20)
- resetStreamer() does not close the underlying Entity Manager HOT 1
- Fieldgenerator yeilds ReferenceField instead of ComparableField HOT 2
- Fieldgenerator should not accept private getter HOT 2
- Illegal reuse of criteria for count()-operator HOT 1
- Merger applies all limit()-operators HOT 1
- Interopoptimizer should only squash adjacent filters and sorts that uses the JPAStreamer metamodel
- Cannot generate $ icon files under annotations folder of generated-sources HOT 4
- Metamodel classes not generated properly when using hibernate validator with quarkus HOT 4
- Add support for toList()
- Add support for mapMulti()
- Support Virtual Thread HOT 1
- jdk 17 support HOT 1
- Filter is not applied in the "where" clause HOT 2
- Check Holon-Platform OSS and bring the good features from there to JPAStreamer
- Java 21 support
- JPAStreamer filter does not work with Hibernate 6.3 or later HOT 4
- Code generator: Include fields from multiple level parent classes
- Hibernate Reactive support
- Filter based on SubEntity (ManyToOne relation) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jpa-streamer.