Giter Club home page Giter Club logo

http-deceiver's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar

Forkers

anandsuresh chalker jacobheun dthadi3 lamweili batmanppc

http-deceiver's Issues

Tests fail on Node.js 4, 6 and 7

Investigate

 ⭠ master ⮀ ~/code/http-deceiver ⮀
» npm test

> [email protected] test /Users/ground-control/code/http-deceiver
> mocha --reporter=spec test/*-test.js



  HTTP Deceiver
    ✓ should emit request
    ✓ should emit response
    ✓ should override .execute and .finish
    ✓ should work with reusing parser
    ✓ should emit CONNECT request
    ✓ should emit Upgrade request
    1) should emit Upgrade response


  6 passing (27ms)
  1 failing

  1) HTTP Deceiver should emit Upgrade response:

      Uncaught AssertionError: false == true
      + expected - actual

      -false
      +true

      at ClientRequest.<anonymous> (test/api-test.js:209:7)
      at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:474:21)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)
      at HTTPParser.execute (lib/deceiver.js:115:31)
      at Socket.socketOnData (_http_client.js:363:20)
      at Deceiver._emitEmpty (lib/deceiver.js:242:17)
      at Deceiver.emitResponse (lib/deceiver.js:127:10)
      at test/api-test.js:217:16
      at _combinedTickCallback (internal/process/next_tick.js:67:7)
      at process._tickCallback (internal/process/next_tick.js:98:9)

Makes #1 even more valuable

[DEP0111] DeprecationWarning: Access to process.binding('http_parser') is deprecated.

Issue

process.binding() is for use by Node.js internal code only.

See: https://nodejs.org/api/deprecations.html#DEP0111

Fix

Use: _http_common

const { methods, HTTPParser } = require("_http_common");

Example implementation in undici:
https://github.com/nodejs/undici/pull/564/files

Test equality

const assert = require("assert");

const { methods: deprecatedMethods, HTTPParser: deprecatedHTTPParser } =
  process.binding("http_parser");
const { methods, HTTPParser } = require("_http_common");

assert.deepStrictEqual(methods, deprecatedMethods);
assert.strictEqual(methods, deprecatedMethods);

assert.strictEqual(
  HTTPParser.kOnHeadersComplete,
  deprecatedHTTPParser.kOnHeadersComplete
);
assert.strictEqual(
  HTTPParser.kOnMessageComplete,
  deprecatedHTTPParser.kOnMessageComplete
);
assert.strictEqual(HTTPParser.kOnBody, deprecatedHTTPParser.kOnBody);

DeprecationWarning: Access to process.binding('http_parser') is deprecated.

It seems this project has been abandoned for years, but spdy depends on it, and hence dependency chain being a headache.

(node:65676) [DEP0111] DeprecationWarning: Access to process.binding('http_parser') is deprecated.
 |     at process.binding (node:internal/bootstrap/loaders:141:17)
 |     at Object.<anonymous> ([redacted]/node_modules/http-deceiver/lib/deceiver.js:22:24)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.