Giter Club home page Giter Club logo

Comments (7)

freekmurze avatar freekmurze commented on May 24, 2024 1

I'll take care of this soon!

from laravel-event-sourcing.

freekmurze avatar freekmurze commented on May 24, 2024 1

Done!

from laravel-event-sourcing.

m-bymike avatar m-bymike commented on May 24, 2024

Just to make it easier, here with links:
Tag 1.1.0 points to commit f72358f

from laravel-event-sourcing.

djallits avatar djallits commented on May 24, 2024

I am going to piggyback off this issue, because I believe it is closely related.

This is what happens when adding the library to my project, which causes a fatal error during package:discover.

$ composer require spatie/laravel-event-sourcing
Using version ^1.0 for spatie/laravel-event-sourcing

If I attempt to explicitly call the v3.0, I receive errors about not meeting library requirements.

$ composer require spatie/laravel-event-sourcing:^3.0
 Package spatie/laravel-event-sourcing at version ^3.0 has a PHP requirement incompatible with your PHP version (7.3) 

However, the version of PHP I am running passes the documented requirements:

PHP 7.3.14 (cli) (built: Feb 1 2020 20:48:29) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.14, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.14, Copyright (c) 1999-2018, by Zend Technologies

from laravel-event-sourcing.

riasvdv avatar riasvdv commented on May 24, 2024

This package has required PHP 7.4 from version 1.1.0, which you can see in composer.json

The requirements weren't updated in the docs correctly, I've fixed that now

from laravel-event-sourcing.

m-bymike avatar m-bymike commented on May 24, 2024

@riasvdv Thank for updating the docs, but I think, this didn't address the problem.

My point is: v1.1.0 is tagging the wrong commit. As outlined above, the actual changelog for v1.1.0 is here: https://github.com/spatie/laravel-event-sourcing/blob/v1/CHANGELOG.md#110---2020-02-07. Compare this to the changelog of the tree of the tagged commit: https://github.com/spatie/laravel-event-sourcing/blob/f72358f0357d8bee7882b94b767cd26a1e160117/CHANGELOG.md

I recommend to drop the v1.1.0 tag, and create a new v1.1.1 to this commit: 851f7e6

from laravel-event-sourcing.

m-bymike avatar m-bymike commented on May 24, 2024

Thank you!

from laravel-event-sourcing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.