AggregateRoot Method is called if Argument has no type-hint about laravel-event-sourcing HOT 8 CLOSED

Hi @zackrowe and @freekmurze
I've bumped the package to the latest version in the example repo I've provided. And now it works!
Thanks @zackrowe for providing a fix for this issue.

from laravel-event-sourcing.

To my knowledge, our packages wouldn't call a custom method like two.
Could you create a minimal Laravel app in which the problem is reproduced?

from laravel-event-sourcing.

Please see https://github.com/fabianpnke/laravel-event-sourcing-issue-341-demo

I've managed to reproduce a behaviour in that the problem results in a 500 Server error by removing a type hint from the method.

from laravel-event-sourcing.

Hi,

same here, when there is a public method in an aggregate with non typed params the app totally breaks.

The break occurs exactly inside the apply function of AggregateRoot.php, in the Handlers section.

from laravel-event-sourcing.

mixed doesnt work as a type either.

from laravel-event-sourcing.

I've also ran into this bug. I believe the issue is in the AggregateRoot class line 259. The method doesn't get filtered when the event gets passed to the accepts() method since the method argument is defined as mixed.

Possible Fix Maybe a method could be added to Handlers to filter methods that don't take a specific argument type? In this case ShouldBeStored?

Temporary Solution I added a second unused argument to my function to get things working. Not ideal but will work for now until this is addressed.

from laravel-event-sourcing.

I've opened a PR in the better-types repository that can hopefully help address this issue. spatie/better-types#3

from laravel-event-sourcing.

@freekmurze I've tested the latest changes in version 7.2.3 in my project and I believe this issue has been resolved.

from laravel-event-sourcing.