Build on toolchain about efsw HOT 3 CLOSED

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

I don't see anything wrong in the Makefile, it's using += so it's appending any previous data.

I exported the flags before calling make and worked as expected:

#!bash


export LDFLAGS+="-L/usr/local/lib64"
export CFLAGS+="-I/usr/local/include"
make config=release -f efsw-static-lib.make verbose=yes

g++ -I/usr/local/include -MMD -MP -DEFSW_VERBOSE -DNDEBUG -I../../include -I../../src  -O2 -Wall -Wno-long-long  -o "../../obj/linux/release/efsw-static-lib/FileWatcherCWrapper.o" -MF ../../obj/linux/release/efsw-static-lib/FileWatcherCWrapper.d -c "../../src/efsw/FileWatcherCWrapper.cpp"

Regards

from efsw.

Original comment by Mihail Slobodyanuk (Bitbucket: mihail_slobodyanuk, ).

It's will be not overriden if you call like:

make CFLAGS="-Os"

see:

https://www.gnu.org/software/make/manual/html_node/Overriding.html

An argument that contains ‘=’ specifies the value of a variable: ‘v=x’ sets the value of the variable v to x. If you specify a value in this way, all ordinary assignments of the same variable in the makefile are ignored; we say they have been overridden by the command line argument.

from efsw.

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

I understand what you say but... it's not relevant to the project, and the "bug" belongs to premake4 project.

This is a problem on how premake generate the Make files, and it's really easy to solve.

You can solve the issue in three easy ways:

1. Exporting as i said in the previous post.

2. Editing the make files generated by premake.

3. Adding the flags in the premake4.lua file. ( using the commands buildoptions and linkoptions ).

Sadly i can't please everyone, i think this problem doesn't deserve any change to the project. If you wan't you can propose a patch, and i'll take it into consideration.

Regards

from efsw.