Comments (3)
Hi! If there's a demand let's simply fix those issues since they seem to require minor fixes. I kind of assumed that no one would be using such an old GCC version so at some point I stopped being careful about it. But I understand that you need that compatibility, right? What's the minimum version you need to be supported?
from efsw.
To be honest, I don't have a strong need to use old compilers myself. I've just been fixing some bugs and will submit a PR later. During this work I noticed the LEGACY option when trying to use C++11 features.
If maintaining the LEGACY option is no longer a priority for the project, I'm happy to help remove it and do some cleanup in a pull request. Let me know if taking out that obsolete option would be helpful.
I don't have a stake in keeping legacy compatibility - just thought I'd raise the issue since the option wasn't working as expected. If the team decides supporting pre-C++11 is more trouble than it's worth, I can assist with removing LEGACY and modernizing the codebase.
from efsw.
Thanks for offering your collaboration. I'm trying to think for a good reason to maintain a pre C++11 version and I honestly don't find any, I remember doing that because there was a single user using an old NAS Linux installation that required support for an old GCC version and old Linux version but it was really long ago. If you want to remove the legacy option please feel free to do it. Thank you very much!
from efsw.
Related Issues (20)
- Filename passed without extension HOT 1
- Cannot track symlinked file in Linux HOT 10
- Bazel Building HOT 1
- On MacOS, actions happening shortly after starting watcher are not reported HOT 19
- CMake multi config issue HOT 2
- Support Windows long path aware HOT 4
- Check Return Code and Allow Buffer Customization in `ReadDirectoryChangesW()` Function HOT 1
- Paranoid exit code? HOT 2
- MacOS build on server HOT 1
- [Bug] Crash while thread running after FileWatcherInotfiy destructed. HOT 16
- Premake5 macosx after gmake2 ... [CI Server] HOT 1
- Last modified file remembered and failing to fire event under Windows HOT 5
- Premake links in ReadMe is dead HOT 1
- FSEventStreamScheduleWithRunLoop has been deprecated in MacOS 13 HOT 3
- Generic file watcher doesn't report new directories on network drives HOT 2
- memory leak doubt and thread conflict HOT 2
- Cross building on macOS may cause `EFSW_FSEVENTS_NOT_SUPPORTED` incorrectly defined HOT 2
- Incorrect move events reported for simultaneous file moves across monitored subdirectories on Windows HOT 9
- Warning C4834 in Log.cpp
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from efsw.