Comments (4)
I've added this in the PR above. By default its not set, if it's defined, it will be added to the styles.
from react-css-collapse.
@deshiknaves was faster 😄. Thank you for adding the feature! It works as expected.
About prefixing the CSS transition: it's supported since IE10, so I guess this should be fine without IE specific prefixes.
from react-css-collapse.
Nice that you like it @grubersjoe! In version 3.4.0
the className is set by default but you still need to define the style in your stylesheet.
Thank you for the feedback. I added a section to the readme to prevent confusion in the future 😊
For now i think it is best to specify the transition yourself but i like the idea of a self contained component including style. If we specify the style the way you propose we have to provide all prefixes. Maybe that is not a big problem. But what if you dont actually want a transition. Then we have to specify transition="" ? Maybe you can create a PR with this feature @grubersjoe ? 🌈
from react-css-collapse.
Thanks again @deshiknaves! Great work.
from react-css-collapse.
Related Issues (10)
- Collapse initialized with "isopen = true" does not render as open
- TypeError: null is not an object (evaluating 'this.content.style') HOT 1
- Update peer dependencies of react & react-dom to v16.1.1? HOT 1
- Create a CONTRIBUTE document HOT 1
- Replace test environment with Jest HOT 3
- ComponentWillReceiveProps warning after upgrade to React 16.9.0 HOT 1
- Transition height on Collapse when it is open and the content changes HOT 3
- overflow:'hidden' on the first render when isOpen = true HOT 3
- `overflow: hidden` should be removed after initial render when `isOpen={true}` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-css-collapse.