Giter Club home page Giter Club logo

Comments (4)

deshiknaves avatar deshiknaves commented on July 21, 2024 2

I've added this in the PR above. By default its not set, if it's defined, it will be added to the styles.

from react-css-collapse.

grubersjoe avatar grubersjoe commented on July 21, 2024 1

@deshiknaves was faster 😄. Thank you for adding the feature! It works as expected.

About prefixing the CSS transition: it's supported since IE10, so I guess this should be fine without IE specific prefixes.

from react-css-collapse.

torleifhalseth avatar torleifhalseth commented on July 21, 2024

Nice that you like it @grubersjoe! In version 3.4.0 the className is set by default but you still need to define the style in your stylesheet.

Thank you for the feedback. I added a section to the readme to prevent confusion in the future 😊

For now i think it is best to specify the transition yourself but i like the idea of a self contained component including style. If we specify the style the way you propose we have to provide all prefixes. Maybe that is not a big problem. But what if you dont actually want a transition. Then we have to specify transition="" ? Maybe you can create a PR with this feature @grubersjoe ? 🌈

from react-css-collapse.

torleifhalseth avatar torleifhalseth commented on July 21, 2024

Thanks again @deshiknaves! Great work.

from react-css-collapse.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.