spapadim / digole Goto Github PK

Hi there, I am struggling with the appalling quality of the Digole library... and i found yours.
I was so hopeful, except that it does not appear to even compile when setting I2C.
Was it tested with interfaces other than serial? Any chances you could kindly have a look?
thanks!

I'm having an issue with the "write" command.

Using i2c, I'm encountering an malfunction where it might not be NUL-terminating the TT command.
For example:

char compress[]="at";
LCD.write('C'); LCD.write(compress,sizeof(compress));

...will display on the screen something like:

"CTTat"

I'm currently converting all my char writes to string writes (of length 2) to temporarily get around this:

char compress[]="at";
LCD.write("C",2); LCD.write(compress,sizeof(compress));

Just a small nitpick... Add a:
category=Display
in the library.properties to get rid of the "Uncategorized" compiler warning.

Move these in a .cpp file!

A suggestion: Have preprocessor/precompiler definition flags for firmware versions?

There are slight issues between versions, such as the background color.
One version of digole firmware has you set the color, then send the background color command, and then clear screen. (v3.2)
Then there's a later version that only requires you to give the color as a parameter in the background color command. (v3.3)

Another example is the "video" command, which is only available after v4.0.