Giter Club home page Giter Club logo

souls-bug-reports's People

Contributors

sovietspaceship avatar

Watchers

 avatar  avatar

souls-bug-reports's Issues

[Elden Ring Inventory Tool] Weapon upgrade level support

Application

Is your feature request related to a problem? Please describe.
I'd love to be able to alter the weapon upgrade levels. I'm using many different rune levels for my builds and while I love the latest update that takes into consideration equipped talismans, displays damage numbers and so on, I'm a little bummed that the damage numbers on display always assume max weapon upgrades.

Describe the solution you'd like
I'd love a text input box (maybe in the stat overview window) that allows me to add the weapon upgrade level I want to go for. A dropdown menu for upgrade levels (regular and somber) would be fine too.

[Elden Ring Inventory Tool] Persist defense/abs in damage calculator

Application

Is your feature request related to a problem? Please describe.
The defense numbers in the weapon damage calculator reset every time I check a new weapon. Meaning I constantly have to readjust the numbers if I'm checking for damage at lower levels.

Describe the solution you'd like
It would be nice if it either saved the numbers in session, in the build or let me make a preset.

Describe alternatives you've considered
If it took my build's defenses as the default every time that could work too.

Additional context
I just started using the build planner and it's amazing, thank you for all great work!

[Elden Ring Inventory Tool] Cannot load inventory by url on first visit

Application

Describe the bug
Opening an inventory URL in an incognito tab shows everything as empty
To Reproduce
Steps to reproduce the behavior:

  1. Open an incognito tab in chrome
  2. Go to an inventory URL e.g. this.
  3. The inventory is empty (if I reload the page, it loads with the expected talismans)

image

Expected behavior
I expect to be able to load other people's URLs, having not visited the site before (empty local storage, might be linked to the bug)

If User Interface issue

  • Device: Desktop
  • Browser: Chrome Version 110.0.5481.180 (Official Build) (64-bit)

[Elden Ring Frame Data Explorer] Black Knife moveset incorrect/missing 1h R2 2

Application

Describe the incorrect or missing data
The entry for the Black Knife/Blade of Calling/Erdsteel Dagger second uncharged 1hR2 appears to have the data for the second charged 1hR2. The entry for the second charged R2 is missing.

Evidence
image

Note that the uncharged R2 1 starts at frame 11, but the uncharged R2 2 is shown to start at frame 25, on par with the charged R2 1 starting at frame 27. In actuality, the 1h R2 2 starts even faster than the R2 1.

[Elden Ring Inventory Tool] More accessible damage calculator

Application

Is your feature request related to a problem? Please describe.
I want to compare how much damage I lose/gain by changing my damage spread, like from 36/36 to 44/28
With 1h R1 attacks I can simply hover over the weapon and see the damage change there.
But with other attacks, like powerstance attacks this won't be accurate.

Describe the solution you'd like
Some way to set which attack is used for the damage tooltip when hovering over weapons

Describe alternatives you've considered
Maybe another view that lets you have the damage calculator visible and not reset in the overview window.
You'd select your weapon from the ones you added to your inventory, rest is same as the one available when adding a new weapon to your inventory

Additional context
image
image

[Elden Ring Frame Data Explorer] Potentially mislabeled attack

Application

Describe the bug
Was double checking that no guard-counters were parriable and saw that 2h dagger/claw guard counter was marked as parriable. Checked the frame data (in the explorer) and saw that it had a release to uncharged speffect which seemed odd. Looked up the tae in DSAnim and it looks to be a 1h straight sword r2. Therefore, I think the attack is mislabeled in the FDE. Filename a022_030510

To Reproduce
Steps to reproduce the behavior:

  1. Set Type to Parriable
  2. Set Attack to 1h Guard Counter and 2h Guard Counter
  3. Open the only result

Screenshots
image
image

[Elden Ring Build & Inventory Planner] [v3.0] Physical types of damage

Application

Is your feature request related to a problem? Please describe.
The feature that I request is related to clarifying the type of physical damage a weapon does, since some of the weapons are vague by their design in explaining what type of physical damage they do.

Describe the solution you'd like
Add the type of physical damage the weapons do between the type of weapon it is (ie: Greatswords, Katanas) , and their ash of war, that being in either side of the marked in the image.
PhyDamage

[Elden Ring Inventory Tool] Effective HP Calculation

Application

Is your feature request related to a problem? Please describe.
I'd really like to see a feature that will let me calculate the effective HP my character has (i.e. a calculator that takes flat defenses and negations into account and spit out the HP my character effectively has so it's easier to figure out if it's more beneficial to invest into heavier armor/endurance or vigor instead). Probably also super interesting for figuring out soreseal math.

Describe the solution you'd like
An EHP number next to the HP number, maybe in brackets like the seconds to fill the stamina bar, would be nice.

[Elden Ring Frame Data Explorer] Filter cannot find offhand attack animations

Application

Describe the bug
Using the Attack filter doesn't work for offhand attacks ever since you did the label transition. Offhand attacks are labeled as Offhand L1 # while the filter searches for Offhand #.

To Reproduce
Steps to reproduce the behavior:

  1. Use Attack filter to search for an offhand attack
  2. Verify that no animations are shown
  3. Clear the filter
  4. Search for offhand using the main search
  5. See that all the off animations are shown

Expected behavior
The filter to be able to display offhand animations correctly

Screenshots
image
image

If User Interface issue

  • Device: Windows 10
  • Browser: Google Chrome 114.0.5735.35 beta

Additional context
No errors or warnings thrown in dev console

[Elden Ring Inventory Tool] Support buffs

Application

Is your feature request related to a problem? Please describe.
When trying to optimize for possible damage, there is something DS3's SoulsPlanner allowed you to do, that none of the ER planners I am aware of are capable of currently, that is to calculate how item buffs (greases or other consumable-based buffs) impact player stats or weapon stats.

Describe the solution you'd like
An implementation akin to how DS3 SoulsPlanner (https://soulsplanner.com/darksouls3) has it; a check box next to the item allows to toggle the player/weapon stats with and without the buff enabled.

Describe alternatives you've considered
Unfortunately, I do not know how else this could be implemented.

Additional context
Having this would allow players to optimize characters for weapon or player buffs without having to trial-and-error or to calculate scaling/AR differences separately.

[Elden Ring Build & Inventory Planner] [v3.2] Damage Calculator / Lance CR1 damage calculation is incorrect

Application

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Open the damage calculator for Lances

Expected behavior
Numbers are reasonable

Screenshots
image

If User Interface issue

  • Device: Desktop
  • Browser: Firefox

Additional context
Add any other context about the problem here.

[Elden Ring Build & Inventory Planner] [v3.2] Custom Ruleset

Application

Is your feature request related to a problem? Please describe.
Tournament Organizer may want to make a custom ruleset, but if the ruleset were too complex they might just want to make it easier to understand.

Describe the solution you'd like
Add something like Custom ruleset Feature that can be saved as template, so any Tournament Organizer can make their own ruleset then give it to their contestant.

[Elden Ring Inventory Tool] Show weapon scalings

Application

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[Elden Ring Inventory Tool] Radagon's Soreseal doesn't change max HP or Equip Load

Application

Describe the bug
Equipping Radagon's Soreseal does not change Equip Load nor HP properly

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Talismans'
  2. Click on an empty Talisman Slot
  3. Equip Radagon's Soreseal
  4. The +5 Vigor and +5 Endurance do not alter the Character's Equip Load or total HP anywhere

Expected behavior
For instance, I'd expect my character's HP to go from 1216HP at 35 Vigor to raise to 1450HP at 35+5 Vigor. The HP or Equip Load values do not change. However, weapon damage and requirements DO change properly. The wrong values are visible in the attached screenshot below.

Screenshots
Bildschirm­foto 2023-05-08 um 11 12 02

[Elden Ring Inventory Tool] Deleting multiples of one item deletes only some

Application

Describe the bug
Deleting multiples of one item deletes some of them (seems to depend on which item you click before clicking 'Select All'

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Weapon Planner'
  2. With an empty inventory
  3. Add 10 cleanrot knight swords with heavy infusion and an ash of war
  4. Click the first sword in your inventory (to select it)
  5. Click 'Select All'
  6. Click 'Remove'
  7. There are now 5 swords in your inventory when there should be 0

Expected behavior
All of the items are removed

  • Device: Desktop
  • Browser: Chrome Version 108.0.5359.126

[Elden Ring Build & Inventory Planner] [v2.18.1] Tags / Tags not saving

When selecting a tag it doesn't stay after selecting save. The tag gets removed and it will only display PvE.

This doesn't happen on all the builds I've made, only a couple. I assume it has to do with the stat allocation. If this is not fixable no big deal, it's just a minor annoyance for me to not have the tags I want set on the builds

[Elden Ring Inventory Tool] Import JSON save

Application

Is your feature request related to a problem? Please describe.
We can export in JSON to have a copy offline, but can't re-import it ?

Describe the solution you'd like
Add the import button to JSON in Load/Save tab

Describe alternatives you've considered
Does the URL-encoded version contain the full data about the build ? or is it just a link

[Elden Ring Build & Inventory Planner] [v2.19] Damage Calculation Component for Two Builds (Duel)

Application

Is your feature request related to a problem? Please describe.
I coded a basic damage calculator for Pokemon Unite for a Duel as well and always wanted the same for Elden Ring and Dark and Darker.

Describe the solution you'd like
A page where you can create or load two builds, one on the left, one on the right and a component in the middle of the screen that shows the damage calculation numbers (HP and HP% e.g.) between the two duelants.

Describe alternatives you've considered
I create two builds, grab all the necessary data for the calculations and then have to manually plug them into an excel calculator or whatever. Seems tedious and prone to errors.

Additional context
I took inspiration from the Pokemon Showdown Calculator where the calculations and strategies can be optimized very handily.
Then me and my group applied the same concept to Pokemon Unite. See my screenshot for reference:
image

[Elden Ring Frame Data Explorer] Earthshaker family errors

Application

Describe the incorrect or missing data
The "Ground Stake", "Ground Stake (no FP)" and "Round Swing" entries are all shared by Earthshaker, Golden Land, and Waves of Darkness. However, only Golden Land and Waves of Darkness have "Startup" and "Startup (no FP)" entries, suggesting that Earthshaker's Startup is missing. But it might not have a startup? I can't tell for sure.

In addition, Waves of Darkness and Golden Land have redundant "Follow-up with FP" entries since these are already covered by "Round Swing".

Hoarah Loux's Earthshaker is also listed erroneously under Radahn's Rain, and Waves of Darkness is listed erroneously under Mighty Shot.

Evidence
image
image
image

Allow filtering by all affinities [Elden Ring Inventory Tool]

Application

Is your feature request related to a problem? Please describe.
As a build maker
I would like to use less critical thinking to determine the optimal affinity
for any given weapon
Using specific stats

Describe the solution you'd like
I would like a system where I can click a button to include all infusions when I sort by damage

Describe alternatives you've considered
I usually use my knowledge to determine the best stat, and go back and forth between alternatives to see the difference

Additional context
Add any other context or screenshots about the feature request here.
image

[Elden Ring Frame Data Explorer] Event Descriptions

Application

Is your feature request related to a problem? Please describe.
Some events in the SpEffect category are not easy to understand the meaning of. For example, spEffectId 89 "Set Damage Level To 1...", spEffectId 32 "Does Not Allow Throws (Grab Attacks)" and spEffectId 144 "Jump Attack Landing Determination - Possible Heavy Landing"

Describe the solution you'd like
I would like to see an explanation of certain events that are not self explanatory such as the ones listed above incorporated into the frame data viewer.

Describe alternatives you've considered
If incorporating explanations or descriptions of events into the viewer is not practical, you could include an easy-to-find link to a relevant document or website that explains what the different events do and what they mean.

Additional context
image
image

[Elden Ring Build & Inventory Planner] [v3.0] Damage Calculator / Dragon Towershield incorrect motion values

Application

Describe the incorrect or missing data
Dragon Towershield displays inflated damage for the 1h r1 1 because it treats the attack as a multi-hit attack with 3 hits

Evidence
Screenshot 2024-03-27 130325

Additional context
When sorting all weapons by damage, this shield will often show up near the top of the list due to this bug

[Elden Ring Inventory Tool] Request for a Two-Handing toggle

Application

Is your feature request related to a problem? Please describe.
I'd love the addition of a two-hand toggle of sorts to display weapon AR values when they're being two-handed rather than only having access to the 1H damage values. Would be especially useful for STR builds.
Alternatively, the 1H and 2H values could be displayed by default on the weapon mouseover popups, though that wouldn't make sorting by 1H or 2H damage amount in the picker possible, which would also be rather nice.

Describe the solution you'd like
I'm kindly requesting adding a toggle to either the inventory manager or stat overview window (possibly both?) to swap between 1H and 2H damage values.

Describe alternatives you've considered
Displaying both 1H and 2H AR values in the weapon mouseover popup could be an alternative to the toggle.

Additional context
eip.gg's build planner has this feature implemented, I think something similar would be a good addition to your build planner as well.
Bildschirm­foto 2023-05-08 um 11 21 54

[Elden Ring Inventory Tool] Failed to load module script

Application

Describe the bug
When I open build planner after PC restart or not using it for sime time, i get grey screen with this error. After reloading page, my talismans are cleared and I have to reload the save file.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://er-build-planner.nyasu.business
  2. See error

Expected behavior
Planner opens and talisman window isn't reset.

Screenshots
image

If User Interface issue

  • Device: Desktop
  • Browser: Chrome 113.0.5672.93

Elden Ring Inventory Tool Talismans Filter

Application

Is your feature request related to a problem? Please describe.
When planning and adding talismans in the Inventory Tool, a lot of the talismans visible are inferior versions and scrolling past them to find what I am looking for slows me down by a whole second each time.

Describe the solution you'd like
A simple filter to only show the strongest version of each talisman.

Describe alternatives you've considered
I could stop being a baby and just scroll.

Additional context
Having the lower tier talismans there is important for planning lower level builds, if one wants to use appropriate talismans for early game. However, most people using these great tools are playing higher level (typically around meta), so a filter for showing the superlative talismans would be nice.
firefox_XbBiS9AXK3

[Elden Ring Inventory Tool] Disable Frame Data button if multiple weapons are selected

Application

Describe the bug
Selecting 3 weapons has the 'view frame data' button available when it should not be
To Reproduce

  1. add 3 identical weapons (or not identical, don't think it matters)
  2. select them all by clicking on them one at a time
  3. Click 'view frame data'
  4. nothing happens

This buttons should not be disabled, or (bonus), it should go to the frame data if all of the selected items have the same frame data (e.g. 3 identical weapons)

Expected behavior
The frame data button be disabled if it is available, or do something if that makes sense

[Elden Ring Build & Inventory Planner] [v3.0] Can no longer login with Discord account

Application

Describe the bug
When i have logged out, i can no longer login with my discord account now. Don´t matter if i use the QR-Code or try it with my login datas. Tested with browser microsoft edge and google chrome.

I can login in the app on my smartphone. So it seems to be an issue with the regular web tool application.

Screenshots
If applicable, add screenshots to help explain your problem.

If i click an enter my Data this should be normal:

image

However you can see below, i am still not logged in:

image

[Elden Ring Build & Inventory Planner] [v2.19.1] Use (roughly) average defensive stats for character's rune level in damage calculator by default

Application

Is your feature request related to a problem? Please describe.
In the Damage Calculator of your build planner, the defensive stats usually assume meta level by default (i.e. flat 150 physical defenses, 30% phys absorption, etc). If at all possible, I'd love to see this feature tweaked for lower level builds, where defenses are usually lower according to the levels of whoever you happen to invade.

Describe the solution you'd like
If at all possible, I'd like to see the Damage Calculator use average defensive stats of the players you'd invade according to the invasion range within the matchmaking by default instead of the flat 150/30 stats that assume meta level. As for how you'd get that data I'm honestly not entirely sure - I'd assume the average flat defenses are easy to figure out since they change according to rune level, but armor defenses are probably a lot trickier. Maybe assume 20ish Absorption at base level and increase that value on a curve according to RL with it topping out at the current 30 at and after meta level?

Describe alternatives you've considered
Using your own character's flat defenses as the default values could also suffice for the most part.

Additional context
For lower level invasion builds it's sometimes harder to figure out which infusion to run to maximise damage, so pulling more accurate defense values for the RL your own character is at would help with that quite a bit.

[Elden Ring Inventory Tool] MassItemGib export causes CE to loop with error after executing

Application

Describe the bug
An error box appears repeatedly after successfully running the Load/Save -> MassItemGib output script

To Reproduce
Run MassItemGib output in CE

Expected behavior
CE should be usable after running the script

Example

alloc(MassItemGib_EldenRingInventoryTool,$2000,eldenring.exe)
createthread(MassItemGib_EldenRingInventoryTool)

MassItemGib_EldenRingInventoryTool:
sub rsp,28
mov rcx,ItemGibArray_EldenRingInventoryTool
call ItemGib
mov rax,MassItemGib_EldenRingInventoryTool_Data
mov dword ptr [rax],00000001
add rsp,28
ret

MassItemGib_EldenRingInventoryTool_Data:
registerSymbol(MassItemGib_EldenRingInventoryTool_Data)
dd 00000000

ItemGibArray_EldenRingInventoryTool:
dd 000FDE80 00000001 FFFF0000 FFFFFFFF // Regular Reduvia 1040000
dd 00116908 00000001 FFFF0000 80004FB0 // Poison Bloodstained Dagger 1141000
dd 0010EFF0 00000001 FFFF0000 FFFFFFFF // Regular Cinquedea 1110000
dd 000F6950 00000001 FFFF0000 FFFFFFFF // Regular Black Knife 1010000
dd 007B4E04 00000001 FFFF0000 800058AC // Cold Beastman's Cleaver 8080900
dd 0131A230 00000001 FFFF0000 FFFFFFFF // Regular Magma Whip Candlestick 20030000
dd 00000000 00000000 00000000 FFFFFFFF

{$lua}
if not syntaxcheck then disableMemrec(memrec, 'MassItemGib_EldenRingInventoryTool') end
{$asm}
[DISABLE]
dealloc(MassItemGib_EldenRingInventoryTool)
unregisterSymbol(MassItemGib_EldenRingInventoryTool)

generated by https://er-inventory.nyasu.business/?b=3caf87577944a2

[Elden Ring Inventory Tool] Create CE Script [Already existing]

Application

Is your feature request related to a problem? Please describe.

Using the "create CE script" function I want to update the talismans in my inventory without updating my weapons. Or vice versa.
At the moment if I have to empty my whole inventory if I want to change either. This is time consuming due to ER's UI not having a "Discard All" function

Describe the solution you'd like
Buttons/functionality to to create a CE script that only creates talismans, and a separate option to create a script that only creates weapons.

Describe alternatives you've considered
N/A

Additional context
N/A

[Elden Ring Frame Data Explorer] Fist 2H Running R2 damageLevel increase

Application

Describe the incorrect or missing data
After Patch 1.09 the hitstun for the Fists 2H Running R2 was reduced, but the DamageLevel is reported to have been increased. In 1.08 is level 2, but in 1.09 is level 3, meaning more stunned frames before one could roll out.

Evidence
Screenshots or details from game data or other supporting tools
image

Additional context
Prior to Patch 1.09, a 2H running R2 could be combo'ed into a 2H R2. Now it's not the case anymore, so it makes no sense that the DamageLevel was increased in the data of 1.09.

[Elden Ring Frame Data Explorer] "HasChanged" tag applied to all multi-hit attacks due to missing values in DamageLevel field

Application

Describe the incorrect or missing data
All multi-hit attacks are missing DamageLevel values for attacks beyond the first in Regulation 1.09, causing these attacks to be flagged with the "HasChanged" tag incorrectly.

Evidence
Urumi 2hcR2 tagged with "HasChanged":
image

DamageLevel field is the only difference, is missing information in 1.09:
image (1)

Additional context
I have not checked every attack in the tool, but can confirm this is at least the case for the 2h claw weapon attacks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.