Giter Club home page Giter Club logo

Comments (4)

keegancsmith avatar keegancsmith commented on June 2, 2024

Those methods are not exported, and they explicitly document the behaviour. I'm unsure why it isn't a map. Maybe @slimsag remembers why?

from appdash.

1046102779 avatar 1046102779 commented on June 2, 2024

but the method 'annotationsFromWire' uses pb data to append annotations, if client annotations with SQL, and the server uses the method to append , and it will be occur overide key= "SQL"

from appdash.

slimsag avatar slimsag commented on June 2, 2024

It's been multiple years since I've looked at Appdash code. Unfortunately, I don't remember why this was done this way.

My best guess: It may have just been that Annotations only need to be unique for a span, so the change of overlap was small if the SQL key included e.g. the actual SQL query being executed (which IIRC was the case).

from appdash.

1046102779 avatar 1046102779 commented on June 2, 2024

i know why.

Annotations type is slice , and its store&get operations is in order, and map is disorder

when we get data from annotations, it keeps original order is pretty good. the same type's data is tobe together. a unit is "_schema:xxx"

        "Client.Request.Headers.Connection":    "close",
        "Client.Request.Headers.Accept":        "application/json",
        "Client.Request.Headers.Authorization": "REDACTED",
        "Client.Request.Proto":                 "HTTP/1.1",
        "Client.Request.RemoteAddr":            "127.0.0.1",
        "Client.Request.Host":                  "example.com",
        "Client.Request.ContentLength":         "0",
        "Client.Request.Method":                "GET",
        "Client.Request.URI":                   "/foo",
        "Client.Response.StatusCode":           "200",
        "Client.Response.ContentLength":        "0",
        "Client.Send":                          "0001-01-01T00:00:00Z",
        "Client.Recv":                          "0001-01-01T00:00:00Z",
         "_schema:HTTPClient":                   "",
       
         ......
        "_schema:msg":  "",
       
        .......
       "_schema:timestamp": "",

from appdash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.