webapp example panic: interface conversion: interface {} is nil, not appdash.SpanID about appdash HOT 5 CLOSED

+1

from appdash.

The offending line in question is https://github.com/sourcegraph/appdash/blob/master/examples/cmd/webapp/main.go#L106

I wonder if this has been broken since net/context was added to the go stdlib? Or maybe something else is just going wrong such that we don't have a span associated with the gorilla context. cc @slimsag

from appdash.

+1

from appdash.

why?

from appdash.

Took a look into this. gorilla/context assumes the *http.Request pointer never changes. However, this is not true. Especially since we now have WithContext which returns a new *http.Request. gorila/mux uses WithContext. It seems there is an open issue about this and it won't be fixed gorilla/context#32

So the proper fix here is to stop using gorilla/context. I'll send a PR for that now.

from appdash.