soryrawyer / monty Goto Github PK

specifically this: https://github.com/SoryRawyer/monty/blob/master/play_song.py#L48

There's gotta be a better way to handle setting up the keyboard events. Right now all the callback functions are declared in main. There's no way that's the best option, right?

Edit 1: Does it make sense to keep these in a separate Callback class? If we make these methods static and rely on partially-evaluating these functions, would that create issues down the line? I believe so. E.g. — if we edit the TrackList after initializing the player, then we won't have a current copy of that TrackList in our callbacks. we'd have to do some kind of update. Come to think of it, we'd probably have to do the same thing if we passed those objects as arguments to the Callback class at the time of initialization.

add an "update callbacks" function that will update bindings for keys/GUI elements.

As Monty moves into the realm of using an index file to know what's up, there are a couple things that need to change:

• The startup for the SQLite database should look for an index file instead of walking the media directory.
  • If no index file available, maybe call out to ingest to create one? I don't really know what's best here.
• TrackList (or something else) should build the file locations from MusicBrainz IDs instead of just, like, knowing what's on disk.
• TrackList should check to see if a file exists before going ahead and playing it. If it doesn't exist, it's gotta go get it.

Expand the Metadata class and use it everywhere (DB, index, tracklist, etc.).

Take out pynput and just use Quartz/AppKit. There probably isn't enough reliance on pynput to justify the dependency.

eed99728e80158fff8456fded682dbd75d6b5b0c

Among things that would be nice to have updated:

• track number (either integer or as a ratio, I'm not sure which would be more useful)

I'm not sure we need anything more than a copy of the audio_tracks table and some cloud storage stuff, but what API endpoints would we need? Some ideas follow.

get_track : artist, album, track_name

(monty) rory@rory:~/dev/monty$ python launch_player.py 
Traceback (most recent call last):
  File "launch_player.py", line 92, in <module>
    main()
  File "launch_player.py", line 20, in main
    client = CloudStorage()

handle errors that could arise from not being able to access Google Cloud and do something useful with them, like display something next to non-local files to say that you can't get to em.
Whatever happens, though, a user should still be able to run the player.

83d7337a94528cec81e33bcf8e315619bdc56845