sontungexpt / url-open Goto Github PK

URLs that contain localhost as the domain, e.g. https://localhost, https://localhost:8000/ are not being recognized by this plugin.

Opening binary file, like PNG image or WAV audio file and scrolling forward causes this error message to pop up:

Error detected while processing CursorMoved Autocommands for "*":
Error executing lua callback: Vim:E976: using Blob as a String
stack traceback:
        [C]: in function 'matchstrpos'
        ...are/nvim/lazy/url-open/lua/url-open/modules/handlers.lua:106: in function 'find_first_url_in_l
ine'
        ...are/nvim/lazy/url-open/lua/url-open/modules/handlers.lua:173: in function 'foreach_url_in_line
'
        ...re/nvim/lazy/url-open/lua/url-open/modules/highlight.lua:48: in function 'highlight_cursor_url
'
        ...hare/nvim/lazy/url-open/lua/url-open/modules/autocmd.lua:35: in function <...hare/nvim/lazy/ur
l-open/lua/url-open/modules/autocmd.lua:34>

Minimal config:

local fn = vim.fn

local lazypath = fn.stdpath("data") .. "/lazy/lazy.nvim"

if not vim.loop.fs_stat(lazypath) then
  if fn.confirm("Download and initialize the configured plugins?", "&Yes\n&No", 2) == 2 then return end
  fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable", lazypath })
end

vim.opt.rtp:prepend(lazypath)

require("lazy").setup(
  {
    'sontungexpt/url-open',
    config = function()
      require("url-open").setup({
        deep_pattern = true,
      })
    end,
  }
)

nvim --version:

NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1697887905

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

Some markdown files have links within <...> (e.g. <https://example.com>)

url-open incorrectly includes the trailing >, which causes the opened link to fail (e.g. rendered as <https://example.com>)

I previously used jghauser/follow-md-links.nvim plugin to open HTTP URLs in MD files.

I like url-open better in that regard, because it works for opening HTTP URLs in all files.

But from follow-md-links I miss being also able to jump in the editor between the linked files e.g. [a relative path file](./../relative_path_file.md) using the same key as opening the browser HTTP URLs.

Considering url-open already handles MD HTTP URL pattern, would you be interested to implement switching in editor between the linked files functionality in url-open?

Or maybe facilitate some way for url-open and follow-md-links to work via the same keyboard shortcut?

From configuration:

require("url_open").setup({})

should be:

require("url-open").setup({})

Great handy plugin! Thank you!

After developing the patterns in #10 , I ran into some things that I'd like to have some more control over, possibly.

1. Some way to control what text is highlighted, not just everything that matches the pattern

This is so that things like the gem or brew prefix don't get highlighted. I'd still like them to be part of the target area. So this is just a cosmetic difference. It's not that big of a deal, but it'd be pretty cool.

2. The ability to pass in a function to build up the URL

I could collapse the two Dockerfile related sections in my other issue if I could control how the URL is built with a function. I could even extend it further and support custom registries fully, by calling a system command to fetch the appropriate URL.

The default version of the function should stick with the current prefix & suffix, it's good enough 90% of the time. This is more of an edge case.

3. The ability to include multiple patterns to match within a file

This is probably pretty hard, from a quick scan through the code. But, being able to include multiple patterns would be a very powerful combo with idea 2.

What do you think? I'm familiar with Lua, so I could take a shot at some of these ideas, but would like your opinion.

Here are some patterns I've created after having this installed for only a few hours, it's been awesome!

To jump to Rubygems from a Gemfile (or it's alternative name, gems.rb):

{                                           
  pattern = "gem ['\"]([^%s]*)['\"]",       
  prefix = "https://rubygems.org/gems/",    
  suffix = "",                              
  file_patterns = { "Gemfile", "gems.rb" }, 
  excluded_file_patterns = nil,             
},                                          

Or to load the URL for a base image in Dockerhub:

-- Dockerfile images: unprefix, unnamespaced (the library images, like `ruby:3.2`) 
-- results in: https://hub.docker.com/_/ruby/                                      
{                                                                                  
  pattern = "^FROM ([^:.]+):",                                                     
  prefix = "https://hub.docker.com/_/",                                            
  suffix = "/",                                                                    
  file_patterns = { "Dockerfile%S*", "Containerfile%S*" },                         
  excluded_file_patterns = nil,                                                    
  extra_condition = function(matched_pattern)                                      
    return not matched_pattern:match("/")                                          
  end,                                                                             
},                                                                                 
-- Dockerfile images: unprefixed but namespaced (like crystallang/crystal)         
-- results in: https://hub.docker.com/r/crystallang/crystal                        
{                                                                                  
  pattern = "FROM ([^:.]+):",                                                      
  prefix = "https://hub.docker.com/r/",                                            
  suffix = "/",                                                                    
  file_patterns = { "Dockerfile%S*", "Containerfile%S*" },                         
  excluded_file_patterns = nil,                                                    
  extra_condition = function(matched_pattern)                                      
    return matched_pattern:match("/")                                              
  end,                                                                             
},

Hello, I'm not trying to be mean, maybe you overlooked it, but there is vim.ui.open method in neovim, it basically does the same thing as this plugin.

For example:

• https://cdn.jsdelivr.net/npm/vue@3
• https://cdn.jsdelivr.net/npm/@honojs/node-server

Hi, not sure if this happened recently or was it always there and I didn't notice.

But today, I opened a .js file that has a URL as a comment, but when I try to open the URL, I get the "no url found" message