sonm-io / blockchain-api-js Goto Github PK
View Code? Open in Web Editor NEWLicense: GNU General Public License v3.0
License: GNU General Public License v3.0
blockchain-api-js/src/entity/Account.js
Line 43 in c814530
inconsistent return statement
both return statement contains falsy value (false, undefined)
maybe method should return short string for new token or empty string otherwise?
blockchain-api-js/src/entity/Account.js
Line 45 in 4622956
is code === address already ?
blockchain-api-js/src/entity/Account.js
Line 53 in 7789e46
blockchain-api-js/src/entity/Account.js
Line 41 in 7789e46
blockchain-api-js/src/entity/Account.js
Line 15 in c814530
Parameter config is not documented and its purpose is not obvious from name or brief look.
In original code there was snmtContract
constructor({ gethClient, address0x, snmtContract, limitGasPrice = GAS_PRICE_MAX, throwGasPriceError = false }) {
invariant(snmtContract && snmtContract.constructor.name === "TruffleContract", 'snmtContract is not valid');
nowadays this.config.contractAddress.token
and method initTokens
are not necessary and increase code complexity, cause we have addToken
method.
blockchain-api-js/src/entity/Account.js
Line 47 in 4622956
needs modular include
import get from 'lodash/get';
import values from lodash/values';
blockchain-api-js/src/entity/Account.js
Line 47 in 4622956
these requests should be parallel
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.