Comments (3)
I have a suggestion (and may want to implement it 🙂)
I can't do that atm :(But I guess it is important we have this issue open to fix models, that contains
nullable
fields, But it shouldn't.Context
Into the Models we have defined some nullable methods for example
Model/Page::getName(): ?string
, and we should return juststring
.
- When you write
new Page()
, no title/slug/name are set, so you require nullable getter or
$page = new Page();
$page->getName();
will crash. Those getters are used by Sonata when you're creating a page.
- Removing those
?
are BC break.
So I think it can be closed.
from sonatapagebundle.
hello, be aware that _page_internal_global have null slug/url/title.
In my app, most of the rows have null title.
By the way i don't really get the point on removing the null return ? In a database pov, i prefer storing null value and not empty string to avoid a return type error
from sonatapagebundle.
hello, be aware that _page_internal_global have null slug/url/title. In my app, most of the rows have null title.
By the way i don't really get the point on removing the null return ? In a database pov, i prefer storing null value and not empty string to avoid a return type error
Hmmm interesting, But don't you need those fields to have pages working 🤔🤔.
If you don't have those fields, how do you use those pages 🤔
from sonatapagebundle.
Related Issues (20)
- Entity is not recognised for new projects HOT 2
- [Doc][Bug] It's throwing an exception when we are decorating PageAdmin HOT 13
- [BUG] Composer (Compose page blocks) gives incorrect position to new created block after deleting few of them HOT 2
- [4.x] doctrine extension version is wrong? HOT 2
- [4.x] Recipe is broken? HOT 6
- Page type filter not working HOT 5
- CmsPageRouter not working
- The SiteAdmin doesn't honor admin option "list_action_button_content" HOT 5
- CmsManagerSelector.isEditor always returns false HOT 2
- Remove Twig form_themes HOT 1
- Removing a page doesn't work from the edit route (works using batch delete) HOT 6
- Switch cocur/slugify to symfony/string HOT 3
- Fix pipeline TransformerInterface HOT 15
- Web profiler not working after runtime added HOT 14
- Decorate `BlockAdmin`, `SnapshotAdmin` and `CreateSnapshotService` HOT 6
- View page button in PageAdmin with multisite HOT 3
- Unable update deprecated RequestFactory::createFromGlobals('host_with_path'); in index.php HOT 16
- Undefined property SonataPageBlock::$lazyObjectState HOT 21
- Add sonata_page twig extension HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonatapagebundle.