Page type filter not working about sonatapagebundle HOT 5 CLOSED

Indeed, the callback wasn't updated
https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Admin/PageAdmin.php#L197

It should be something like

'callback' => static function (ProxyQueryInterface $queryBuilder, string $alias, string $field, FilterData $data): void {
                    $builder = $queryBuilder->getQueryBuilder();

                    if (\in_array($data->getValue(), ['hybrid', 'cms'], true)) {
                        $builder->andWhere(sprintf('%s.routeName %s :routeName', $alias, 'cms' === $data->getValue() ? '=' : '!='));
                        $builder->setParameter('routeName', PageInterface::PAGE_ROUTE_CMS_NAME);
                    }
                },

from sonatapagebundle.

Seems that the issue is on 197:113 instead of a array the type should be \Sonata\AdminBundle\Filter\Model\FilterData
and instead of data['value'] it should be data->getValue()

from sonatapagebundle.

you got me some minutes earlier ;) I tried this already but there is also an issue with the twig sonat-admin/resources/CRUD/base_list.html.twig the issue is that the callback should return also some boolean so the type should be changed from void to bool and the proper bool should be returned accordingly

so it should be

'callback' => static function (ProxyQueryInterface $queryBuilder, string $alias, string $field, \Sonata\AdminBundle\Filter\Model\FilterData $data): bool {
$builder = $queryBuilder->getQueryBuilder();

                if (\in_array($data->getValue(), ['hybrid', 'cms'], true)) {
                    $builder->andWhere(sprintf('%s.routeName %s :routeName', $alias, 'cms' === $data->getValue() ? '=' : '!='));
                    $builder->setParameter('routeName', PageInterface::PAGE_ROUTE_CMS_NAME);
                }

                return true;
            },

but it should not always return true I guess

from sonatapagebundle.

I guess I can overwrite the admin with some extension until this get's fixed

from sonatapagebundle.

I guess I can overwrite the admin with some extension until this get's fixed

You can also provide a PR with the fix and I'll review/merge/release it.

from sonatapagebundle.