Here is a summary of the changes made to the process, changes that end up with a tricky process to make the match.
This issue will server as a place to discuss alternatives to change the actual process.

Note: This issue shouldn't be attempted to be addressed until #41 is done, this as a preventive measure to avoid introducing more bugs/regressions.

The plugin should work if an analysis is executed from a Windows machine.
For now the only blocker for this is the Scoverage module, more precisely the filename matching process. Reason why it would be better not try to address this until #64 is done.

Note: this is not as priority as other issues at the moment. (e.g. #41, #64, #8).

https://github.com/sksamuel/scapegoat/releases/tag/v1.3.7

Probably don't add too much value (therefore not so priority). But is somewhat sad not having it.

By looking at this. It seems that is not so difficult to add it, and probably scalariform already does all the hard work for us.

Hello,
I downloaded the latest .jar and added it to the extensions/plugins folder. When I restarted the SonarQube it fails to load.

Please help.

SonarQube version - 6.7.1 (build 35068)

when this .jar is removed from extensions/plugins folder, Sonar works fine.

As discussed in #34, we should add support for the new Key (sonar.scala.scoverage.reportPath) while maintaining the support for the old one (sonar.scoverage.reportPath) but adding a deprecation warning, and finally drop the support for the old one when addressing #11.

It would be good to have a microsite with detailed instructions on how to set everything up, how to use and configure the plugin, how to set up quality profiles with sonar-scala rules etc.

It is currently used only in one place.

Here is a task list with high-level items so we can keep track of implementation progress:

• Ingestion of Scapegoat inspections - (#50, @BalmungSan)
• Scapegoat Rules Repository - (#59, @BalmungSan)
• Scapegoat Quality Profile - (#69, @BalmungSan)
• Scapegoat Sensor - (#71, @BalmungSan)
• A mechanism for blacklisting inspections (#59 - @BalmungSan)
• Scapegoat feature flag (#76 - @mwz)
• Docs & release (#77 - @mwz)

Here is an example of an existing Scapegoat plugin https://github.com/arthepsy/sonar-scala-extra.

Is there an equivalent of SonarJava's ""deprecated code should not be used"?

We want it to show up in sonar as a violation, so developers will notice it. However, we can't seem to find a similar rule both in Scalastyle and Scapegoat.

Posted the same question to Scalastyle github, but it seems pretty inactive.

see discussion in #19

Due to security implications with passing secrets to builds from forked pull requests in CircleCI, we'll need a different mechanism to execute sonar-scanner for PRs.

• SBT code generation task, to create a file with all the Scalastyle rules. (@mwz, #101)
• Scalastyle rules repository. (@mwz, #105)
• Scalastyle quality profile. (@mwz, #108)
• Scalastyle sensor (Includes feature flag). (@mwz, #114)
• Docs, examples & release.

Is there some way to get code duplication also working???

Rule for org.scalastyle.scalariform.ProcedureDefinitionChecker not found in Scalastyle repository! Rule won't be activated.

The correct rule is called ProcedureDeclarationChecker.

https://docs.sonarqube.org/display/SONAR/Metric+Definitions#MetricDefinitions-Duplications

Use JavaConverters instead.

At this moment the ScoverageSensor, and the ScapegoatSensor use the infamous 🍰 pattern to be able to mock their respective report parsers in their tests.

Nevertheless, there is a reason for using it.

But probably there is a better way to do it, using dependency injection. However, it appears that it only works for SonarQube API classes and not with user defined classes. But maybe I just missed something when I tried it a first.

Migrate away from deprecated apis.

• variable DOMAIN_TESTS in object CoreMetrics is deprecated
• trait Sensor in package batch is deprecated
• trait CoverageExtension in package batch is deprecated
• trait SensorContext in package batch is deprecated
• trait RuleFinder in package rules is deprecated
• trait ResourcePerspectives in package component is deprecated
• class Settings in package config is deprecated
• class Project in package resources is deprecated
• class Measure in package measures is deprecated
• class ProfileDefinition in package profiles is deprecated
• class Resource in package resources is deprecated
• method getMeasure in trait SensorContext is deprecated
• method inputDir in trait FileSystem is deprecated
• method files in trait FileSystem is deprecated
• method message in trait IssueBuilder is deprecated
• method line in trait IssueBuilder is deprecated

It would be good to have examples for:

• sbt (single and multi-module) - #66, @mwz
• maven (single and multi-module) - #66, @mwz
• maven mixed Scala/Java - #67, @mwz
• gradle (single and multi-module) - #62, @mwz

Including https://github.com/scala/scala-java8-compat as a dependency would make our life a bit easier in the future when dealing with Scala <-> Java conversions.

It looks like Wartremover doesn't generate any report which could be imported to SonarQube, therefore support for Wartremover might not be currently possible.

I raised the following issue to find out more about the support for report generation: wartremover/wartremover#419.

In my project, ScoverageSensor.getModuleSourceFiles() includes "src/main/scala" and filename attributes in scoverage.xml do not. This means that ScoverageSensor reports that there is no coverage information for all files.

Is there a configuration I'm missing to strip or add this part of the path from the reporting?

I'm running through maven with the sonar maven plugin.

This probably only applies to the sbt projects, although it might be possible to get it also working with Maven. I'm not sure if there is a way to run Scapegoat with Gradle projects.

The following deprecation warnings are shown when running sonar analysis:

WARN: Coverage measure for metric 'lines_to_cover' should not be saved directly by a Sensor. Plugin should be updated to use SensorContext::newCoverage instead.
WARN: Coverage measure for metric 'uncovered_lines' should not be saved directly by a Sensor. Plugin should be updated to use SensorContext::newCoverage instead.
WARN: Coverage measure for metric 'coverage_line_hits_data' should not be saved directly by a Sensor. Plugin should be updated to use SensorContext::newCoverage instead.

Currently, the way the Scoverage sensor parses Scala version in ScoverageSensorInternal.getDefaultScoverageReportPathrequires the major, minor, and the patch versions to be present and it will fail in cases where either the user doesn't specify a patch version or, for some reasons, the patch version includes more than one identifier (subversions), which is allowed by semver e.g. 2.12, 2.12.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92 etc.

We should parse the version so that only the major and minor versions are mandatory and the patch version is optional, e.g. 2.11, 2.12 should be allowed.

Hi @mwz,

As I mentioned in Sagacify/sonar-scala#8 the scoverage plugin is not working for me, I had created a dummy project to reproduce the problem. (BalmungSan/SonarScala-Scoverage-Test).

I scan the project using the following command in the sbt shell, ";coverageOn;clean;test;coverageReport;scapegoat;sonarScan;coverageOff".

But, this is what is show in the sonar web page.

And there is no "coverage" measure for the project.

The DirOrFile class located in the XmlScoverageReportConstructingParser.scala file should be refactored to either be fully immutable or not being a case class.

Also the class has the following associated warning: "The outer reference in this type test cannot be checked at run time." that should be addressed. I think that after refactoring the class this warning should disappear.

Hi,

I have added a custom rule. Please see below.

When I do the scan this rule is not working (I have hardcoded IP address in my code). Can you please help.

We should add the Artima SuperSafe scala compiler, to ensure the tests written with ScalaTest are completely typesafe.

For reference see this

Scalatest produces "junit xml" files describing the test class, test name, and duration of the test. For a java project, Sonar will read this file and update the "Unit Test Count." This plugin does not provide a way to read in these junit xml files. Other sonar-scala plugins (https://github.com/RadoBuransky/sonar-scala/blob/master/src/main/java/org/sonar/plugins/scala/surefire/SurefireSensor.java) do provide this via the property

sonar.junit.reportPaths=build/test-results/

Is there a way to already do this that I don't see? (if so, please point me to the docs)
If not, can mwz/sonar-scala incorporate this type of sensor?

Hi, we are using sonar-scala with our SonarQube server and TeamCity build server.

In TeamCity we have a build step which runs SonarQube checks.

We get an error in ScalaSensor for ScalaStyle checks:
[11:06:58][Step 4/4] 10:06:59.518 ERROR - Got exception message from Scalastyle. Check you have valid parameters configured for all rules. Exception message was: illegal start of simple expression: Token(RPAREN,),4366,))

The code, tests and coverage all run without problems.

I did run the SonarQube checks with verbose output but this still does not help me to find the problem.

This is the abbreviated log from TeamCity

[11:06:38]Step 4/4: SonarQube Runner (25s)
[11:06:38][Step 4/4] Starting SQR in D:\BuildAgent.1\plugins\sonar-plugin-agent\sonar-qube-runner\bin\sonar-runner.bat
[11:06:38][Step 4/4] -Dproject.home=.
[11:06:38][Step 4/4] -Dsonar.host.url=http://sonarqube.rwe.com:9000
[11:06:38][Step 4/4] -Dsonar.projectKey=CaoGasCe_GsaPlatformNew_TopGun
[11:06:38][Step 4/4] -Dsonar.projectName=TopGun
[11:06:38][Step 4/4] -Dsonar.projectVersion=0.6.0.53
[11:06:38][Step 4/4] -Dsonar.sources=src/main
[11:06:38][Step 4/4] -Dsonar.tests=src/test
[11:06:38][Step 4/4] -Dsonar.binaries=target/scala-2.12/classes
[11:06:38][Step 4/4] -Dsonar.java.binaries=target/scala-2.12/classes266b2cbac87a3f7
[11:06:38][Step 4/4] -Dsonar.sourceEncoding=UTF-8
[11:06:38][Step 4/4] -Dsonar.scala.version=2.12.5
[11:06:38][Step 4/4] -Dsonar.scoverage.reportPath=target/scala-2.12/scoverage-report/scoverage.xml
[11:06:38][Step 4/4] -Dsonar.verbose=true
[11:06:39][Step 4/4] SonarQube Runner 2.4
[11:06:39][Step 4/4] Java 1.8.0_151 Oracle Corporation (64-bit)
[11:06:39][Step 4/4] INFO: SonarQube Server 6.7.2.37468
[11:06:42][Step 4/4] 10:06:43.434 INFO  - Publish mode
[11:06:43][Step 4/4] 10:06:45.033 INFO  - Load global settings
[11:06:44][Step 4/4] 10:06:45.394 INFO  - Load global settings (done) | time=362ms
[11:06:44][Step 4/4] 10:06:45.455 INFO  - User cache: C:\Users\SRV_RWEST_TC_BUILD\.sonar\cache
[11:06:44][Step 4/4] 10:06:46.108 INFO  - Load plugins index
[11:06:44][Step 4/4] 10:06:46.286 INFO  - Load plugins index (done) | time=178ms
[11:06:44][Step 4/4] 10:06:46.286 DEBUG - Load plugins
[11:06:45][Step 4/4] 10:06:46.446 DEBUG - Download plugin sonar-scala_2.12-6.2.0-assembly.jar to C:\Users\SRV_RWEST_TC_BUILD\.sonar\cache\_tmp\fileCache5878176986894495384.tmp
[11:06:45][Step 4/4] 10:06:46.458 DEBUG - GET 200 http://sonarqube.rwe.com:9000/deploy/plugins/scala/sonar-scala_2.12-6.2.0-assembly.jar | time=12ms
[11:06:46][Step 4/4] 10:06:48.078 DEBUG - Load plugins (done) | time=1792ms
[11:06:47][Step 4/4] 10:06:48.517 DEBUG - Plugins:
[11:06:47][Step 4/4] 10:06:48.517 DEBUG -   * GitHub 1.4.2.1027 (github)
[11:06:47][Step 4/4] 10:06:48.517 DEBUG -   * SonarPython 1.9.1.2080 (python)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * Scala 6.2.0 (scala)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * Svn 1.7.0.1017 (scmsvn)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * SonarJS 4.1.0.6085 (javascript)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * SonarC# 7.0.1.4822 (csharp)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * SonarJava 5.3.0.13828 (java)
[11:06:47][Step 4/4] 10:06:48.518 DEBUG -   * LDAP 2.2.0.608 (ldap)
[11:06:47][Step 4/4] 10:06:48.520 DEBUG -   * SonarWeb 2.6.0.1053 (web)
[11:06:47][Step 4/4] 10:06:48.520 DEBUG -   * Git 1.4.0.1037 (scmgit)
[11:06:47][Step 4/4] 10:06:48.521 DEBUG -   * SonarFlex 2.4.0.1222 (flex)
[11:06:47][Step 4/4] 10:06:48.521 DEBUG -   * SonarXML 1.5.0.1373 (xml)
[11:06:47][Step 4/4] 10:06:48.521 DEBUG -   * SonarPHP 2.12.1.3018 (php)
[11:06:47][Step 4/4] 10:06:48.521 DEBUG -   * SonarTS 1.6.0.2388 (typescript)
[11:06:47][Step 4/4] 10:06:48.521 DEBUG -   * SVG Badges 2.0.1 (status)
[11:06:50][Step 4/4] 10:06:51.471 INFO  - Process project properties
[11:06:50][Step 4/4] 10:06:51.500 INFO  - Load project repositories
[11:06:50][Step 4/4] 10:06:51.810 INFO  - Load project repositories (done) | time=310ms
[11:06:50][Step 4/4] 10:06:51.817 INFO  - Execute project builders
[11:06:50][Step 4/4] 10:06:51.818 INFO  - Execute project builders (done) | time=1ms
[11:06:50][Step 4/4] 10:06:52.088 DEBUG - Available languages:
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * Python => "py"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * Scala => "scala"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * JavaScript => "js"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * C# => "cs"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * Java => "java"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * Web => "web"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * Flex => "flex"
[11:06:50][Step 4/4] 10:06:52.088 DEBUG -   * XML => "xml"
[11:06:50][Step 4/4] 10:06:52.089 DEBUG -   * PHP => "php"
[11:06:50][Step 4/4] 10:06:52.089 DEBUG -   * TypeScript => "ts"
[11:06:50][Step 4/4] 10:06:52.118 INFO  - Load quality profiles
[11:06:50][Step 4/4] 10:06:52.268 INFO  - Load quality profiles (done) | time=150ms
[11:06:50][Step 4/4] 10:06:52.375 INFO  - Load active rules
[11:06:51][Step 4/4] 10:06:53.310 INFO  - Load active rules (done) | time=935ms
[11:06:51][Step 4/4] 10:06:53.318 INFO  - Load metrics repository
[11:06:52][Step 4/4] 10:06:53.421 INFO  - Load metrics repository (done) | time=103ms
[11:06:52][Step 4/4] 10:06:53.584 INFO  - Project key: CaoGasCe_GsaPlatformNew_TopGun
[11:06:52][Step 4/4] 10:06:53.585 INFO  - -------------  Scan TopGun
[11:06:52][Step 4/4] 10:06:54.151 INFO  - Load server rules
[11:06:52][Step 4/4] 10:06:54.246 INFO  - Load server rules (done) | time=94ms
[11:06:52][Step 4/4] 10:06:54.317 INFO  - Base dir: D:\BuildAgent.1\work\topgun
[11:06:52][Step 4/4] 10:06:54.317 INFO  - Working dir: D:\BuildAgent.1\work\topgun\.sonar
[11:06:52][Step 4/4] 10:06:54.319 INFO  - Source paths: src/main
[11:06:52][Step 4/4] 10:06:54.319 INFO  - Test paths: src/test
[11:06:52][Step 4/4] 10:06:54.319 INFO  - Source encoding: UTF-8, default locale: en_GB
[11:06:53][Step 4/4] 10:06:54.755 INFO  - Index files
[11:06:53][Step 4/4] 10:06:54.950 INFO  - 40 files indexed
[11:06:53][Step 4/4] 10:06:54.953 INFO  - Quality profile for js: Sonar way
[11:06:53][Step 4/4] 10:06:54.953 INFO  - Quality profile for scala: Scalastyle
[11:06:53][Step 4/4] 10:06:54.953 INFO  - Quality profile for xml: Sonar way
[11:06:56][Step 4/4] 10:06:57.792 DEBUG - Sensors : com.ncredinburgh.sonar.scalastyle.ScalastyleSensor@f5bf288 -> Scala Sensor -> Scoverage Sensor -> SonarJS -> SonarJS Coverage -> SonarJavaXmlFileSensor -> XML Sensor -> Zero Coverage Sensor -> CPD Block Indexer
[11:06:56][Step 4/4] 10:06:57.793 INFO  - Sensor com.ncredinburgh.sonar.scalastyle.ScalastyleSensor [scala]
[11:06:56][Step 4/4] 10:06:57.901 DEBUG - Using config ScalastyleConfiguration(sonar,true,List(ConfigurationChecker(org.scalastyle.scalariform.EqualsHashCodeChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.EqualsHashCodeChecker),None,Some(scalastyle_EqualsHashCodeChecker)), ConfigurationChecker(org.scalastyle.scalariform.StructuralTypeChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.StructuralTypeChecker),None,Some(scalastyle_StructuralTypeChecker)), ConfigurationChecker(org.scalastyle.scalariform.ForBraceChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.ForBraceChecker),None,Some(scalastyle_ForBraceChecker)), ConfigurationChecker(org.scalastyle.scalariform.NoCloneChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NoCloneChecker),None,Some(scalastyle_NoCloneChecker)), ConfigurationChecker(org.scalastyle.file.FileTabChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.file.FileTabChecker),None,Some(scalastyle_FileTabChecker)), ConfigurationChecker(org.scalastyle.scalariform.SpacesBeforePlusChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.SpacesBeforePlusChecker),None,Some(scalastyle_SpacesBeforePlusChecker)), ConfigurationChecker(org.scalastyle.scalariform.SpacesAfterPlusChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.SpacesAfterPlusChecker),None,Some(scalastyle_SpacesAfterPlusChecker)), ConfigurationChecker(org.scalastyle.scalariform.NoWhitespaceBeforeLeftBracketChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NoWhitespaceBeforeLeftBracketChecker),None,Some(scalastyle_NoWhitespaceBeforeLeftBracketChecker)), ConfigurationChecker(org.scalastyle.scalariform.UppercaseLChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.UppercaseLChecker),None,Some(scalastyle_UppercaseLChecker)), ConfigurationChecker(org.scalastyle.scalariform.NoFinalizeChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NoFinalizeChecker),None,Some(scalastyle_NoFinalizeChecker)), ConfigurationChecker(org.scalastyle.scalariform.SpaceAfterCommentStartChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.SpaceAfterCommentStartChecker),None,Some(scalastyle_SpaceAfterCommentStartChecker)), ConfigurationChecker(org.scalastyle.file.NewLineAtEofChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.file.NewLineAtEofChecker),None,Some(scalastyle_NewLineAtEofChecker)), ConfigurationChecker(org.scalastyle.scalariform.CovariantEqualsChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.CovariantEqualsChecker),None,Some(scalastyle_CovariantEqualsChecker)), ConfigurationChecker(org.scalastyle.scalariform.SimplifyBooleanExpressionChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.SimplifyBooleanExpressionChecker),None,Some(scalastyle_SimplifyBooleanExpressionChecker)), ConfigurationChecker(org.scalastyle.scalariform.ReturnChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.ReturnChecker),None,Some(scalastyle_ReturnChecker)), ConfigurationChecker(org.scalastyle.scalariform.NoWhitespaceAfterLeftBracketChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NoWhitespaceAfterLeftBracketChecker),None,Some(scalastyle_NoWhitespaceAfterLeftBracketChecker)), ConfigurationChecker(org.scalastyle.scalariform.NotImplementedErrorUsage,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NotImplementedErrorUsage),None,Some(scalastyle_NotImplementedErrorUsage)), ConfigurationChecker(org.scalastyle.scalariform.NoWhitespaceBeforeRightBracketChecker,ErrorLevel,true,Map(scalastyle-checker -> org.scalastyle.scalariform.NoWhitespaceBeforeRightBracketChecker),None,Some(scalastyle_NoWhitespaceBeforeRightBracketChecker))))
[11:06:58][Step 4/4] 10:06:59.518 ERROR - Got exception message from Scalastyle. Check you have valid parameters configured for all rules. Exception message was: illegal start of simple expression: Token(RPAREN,),4366,))
[11:06:58][Step 4/4] 10:06:59.518 INFO  - Sensor com.ncredinburgh.sonar.scalastyle.ScalastyleSensor [scala] (done) | time=1725ms
[11:06:58][Step 4/4] 10:06:59.518 INFO  - Sensor Scala Sensor [scala]
[11:06:58][Step 4/4] 10:06:59.712 INFO  - Sensor Scala Sensor [scala] (done) | time=194ms

I don't think this dependency is used anywhere and we should remove it from the project.

We're using version 6.2.0 of the plugin, but when running the sonarqube task from Gradle it seems that it somehow fails to parse the scoverage.xml report, even though it finds it and loads it successfully.

These are the errors I am seeing:

[scoverage] Initializing the scoverage sensor.
[scoverage] Successfully loaded the scoverage report file: 'C:\Users\dmarkhas\IdeaProjects\sdk-base\build\reports\scoverage\scoverage.xml'.
[scoverage] The file: 'src/main/scala/com/intel/daas/sdk/Launcher.scala' has no scoverage information associated with it.
[scoverage] The file: 'src/main/scala/com/intel/daas/sdk/application/AbstractSparkApplication.scala' has no scoverage information associated with it.
[scoverage] The file: 'src/main/scala/com/intel/daas/sdk/application/ApplicationContext.scala' has no scoverage information associated with it.

I saw #51 but in this case the filenames match exactly the filenames in the xml report so I'm not sure what's wrong. I've attached the scoverage report (had to rename from .xml to .txt for GitHub) - anything obvious I am missing perhaps?

scoverage.txt

The README.md states there should be an artifact on the github releases page. There is not.

So either the README.md is out of date, or the CI system is not correctly uploading all your files.

(I opened a pull request giving basic build instructions in case you don't want to provide downloadable jars)

The Cats library could helps to simplify some parts of our code and allow us to stay functional.

The point of this issue is to identify all places where Cats should be used, to raise a PR making all those changes at once.

Here is a list of Scapegoat and Scalastyle rules that we disabled or changed the severity for in the public SonarQube instance, so we could use it as a reference.

disabled:

• common-scala:InsufficientCommentDensity - Source files should have a sufficient density of comment lines
• scapegoat:com.sksamuel.scapegoat.inspections.unneccesary.UnnecessaryReturnUse - Checks for use of `return` keyword in blocks
• scapegoat:com.sksamuel.scapegoat.inspections.imports.WildcardImport - Checks for wildcard imports
• scapegoat:com.sksamuel.scapegoat.inspections.RedundantFinalModifierOnCaseClass - Redundant final modifier on case class - update: does not exist in the latest version of Scapegoat
• Scalastyle:scalastyle_BlockImportChecker - Avoid block imports
• Scalastyle:scalastyle_UnderscoreImportChecker - Avoid wildcard imports
• Scalastyle:scalastyle_LowercasePatternMatchChecker - Lowercase pattern match
• Scalastyle:scalastyle_NoNewLineAtEofChecker - No Newline at EOF
• Scalastyle:scalastyle_PatternMatchAlignChecker - Pattern match align

changed severity:

• Scalastyle:scalastyle_SpaceAfterCommentStartChecker - MINOR - Space after the start of the comment

This list doesn't include any changes to Scalastyle templates, but we'll update it once we review those as a part of #35.

It's currently hardcoded to 2.11.8.

The CyclomaticComplexityChecker from ScalaStyle could be potentially used for this metric.
SonarQube reference

The existing SonarQube Github plugin reports only on issues found in a pull request, but it doesn't report any coverage changes that were introduced by the new code.
It would be great to have some coverage feedback on opened PRs, similarly to the way how codecov integrates with Github, see an example.

This functionality should probably sit in a separate plugin, but I thought I'd open a new issue here just to kick off some discussion.

See this

The idea is to address all those errors, or at least the majority of them.
For the moment I will wait until @mwz update the sonar rules and scan the project again, so we can work on the real set of errors.
Also I suppose you will add the sonar scanner as a step in the PR CI pipeline, so we can track our progress as we push commits.

• https://www.sonarqube.org/sonarqube-7-3
• https://jira.sonarsource.com/jira/secure/ReleaseNote.jspa?projectId=10930&version=14464