solymosi / npu Goto Github PK

Hello!
I think this can be a good feature to add ability to store multiple lessons for one subject with priority (1,2,3, etc), and when the user clicks the pick up button it tries to pick up the first, if it fails it tries the second etc. So if teher are multiple times that are appropriate for the user it is faster if there is an error, check the box again and click the button.

Jó lenne egy olyan opció, hogy a minden bejelentkezéskor megjelenő "Önnek kitöltendő kérdőíve van" felugró ablakot el lehessen rejteni. uBlock Origin-nel megoldtam, de esetleg NPU-ba is bele lehetne írni.

Szia!
Nekem olyan gondom lenne hogy Chromeban és firefoxban is miután felraktam a tampermonkey-t és azon belül telepítem a scriptet azt elfogadja, de utána hiába megyek neptunra ott azt írja nem fut egyetlen script sem.
Mit csinálok rosszul?

Ha be van kapcsolva a script akkor hibaüzenetet dob a Neptun, de eddig hibátlanul ment...
Hibaüzenet:
Kiszolgálóhiba történt az alkalmazásban: „/hallgato”.

MacBook, Safari, Tampermonkey, legfrissebb PowerUp.

Köszi a scriptet!

If Neptun is opened again with an active session, thus bypassing the login screen, the last open page feature does not work.

The "loadLastPage" function crashes if there is no saved last page yet in the storage.

Example ELTE:

BME:

A neptun amint beléptem az órarendtervezőbe kidobott a bejelentkezési képernyőre, semmilyen hiba üzenetet nem kaptam.

Egy pár hete egy új funkció került a Neptun bejelentkezéshez (csak néhány egyetemen egyelőre, de gondolom szépen lassan minden egyetem meg fog jelenni), mégpedig egy captcha, ami miatt nem működik az automatikus bejelentkezés.

Fork-oltam a repo-t, és a TrueCaptcha API használatával megcsináltam, hogy a neptunkód és jelszó mellett a captcha-t is kitöltse a script automatikusan.

(A truecaptcha nem egy ingyenes szolgáltatás, de nevetségesen olcsó, így nem gondolnám, hogy az embereknek ez a része gondot okozna. 1$-ért cserébe 3000 captcha-t old meg, amit szerintem egy átlag egyetemista a teljes egyetemi képzése alatt sem használna fel)

Lenne rá igény, hogy csináljak egy PullRequest-et és bekerüljön ez is a többi hasznos funkció mellé?

Dear Mate,

Any suggestion on this? Got it on all computers I tried recently. Even tried with C+P to tampermonkey and run from there - didn't work.

Sajnos valamilyen okból kifolyólag az utóbbi időben (nem tudom pontosan, de augusztusban már biztos tapasztaltam) nem működik megfelelően az automatikus kiléptetést gátló mechanizmus és ugyanúgy kidob, ha x ideig tétlen maradsz. Károlis Neptunról van szó az esetemben, tavaszi tárgyfelvételnél még nem volt ilyen probléma.

Vizsgafelvétel kezdete előtt nincs lehetőség a vizsgaidőpontokat órarendtervezőbe adni. PPKE neptun.

I don’t know better place to note this: GreaseMonkey is now rewritten as a WebExtension, so it works on Firefox 57+, the warning can be removed from the website.

It is quite frustrating when a course gets full, so when the study department adds some free places, you don't want to miss it. It would be great to have a feature where you do not have to check the course frequently, but rather get a notification about the newly added free places.
Is is possible to implement into the npu project?

HU: Feliratkozás kurzus-férőhely kibővítésről szóló értesítésre
Elég zavaró tud lenni, ha tárgyfelvételkor egy kurzus betelik, ezért amikor előfordul, hogy utólag a tanulmányi osztály kibővíti a férőhelyeket, nem kéne lekésni. Nagy segítség lenne, ha nem kellene rendszeresen nézegetni a neptunt, hanem emailben értesítene a kurzus kibővítéséről. Ez vajon megvalósítható az npu-n keresztül?

My curriculum is mixed between English and Hungarian. So I often use Language-Switching-Feature in the header of Neptun. However, Header-Remove-Feature removed the banner, so I no longer can access this.
Can you add a drop-down menu in the menu bar? Or a floating button to change the language?

Ideas for improving code quality:

• Convert tabs to spaces, remove trailing whitespace.
• Use ES5 features instead of the corresponding jQuery helper functions (e.g. $.inArray).
• Don't use $ for data storage by setting random properties on it (e.g. $.examSubjectFilterCache or $.examListSubject).
• Break source code out into multiple source files and use a preprocessor to generate the final script. Possibly minify it too, though that may decrease the trust in potential users that they aren't installing something malicious.
• Implement a small framework for splitting up functionality into separate, independent modules. Prevent modules from interfering with each other. Create a globally accessible place for generic helper methods. Have the page detection logic as part of the module framework. This will later allow us to let users selectively enable and disable specific features of the script.
• Refactor user data management functions getUserData and setUserData to make the parameterization more trivial.
• A common theme throughout the script is the use of a timer and a data-* marker to detect when Neptun reloads an element and reapply our enhancements if that happens. This could be extracted into a global function, which would set up the proper timers and markers and simply execute a callback function when it's time to perform the enhancements (again). Doing this would also let all enhancements share the same setInterval timer, improving performance. Example:

npu.enhanceElement("#h_markbook_gridIndexEntry_bodytable", function() {
  // this is called whenever the element is recreated by Neptun
}

• Add a global function for easier injection of CSS styles. Example:

npu.injectCssRule(".termSelect li", {
  "display": "inline-block",
  "vertical-align": "middle"
});

// ==UserScript==
// @name Neptun New Messages Auto Read
// @namespace http://tampermonkey.net/
// @Version 0.1
// @description try to take over the world, or just read the messages.
// @author Krachi9
// @match https://frame.neptun.bme.hu/hallgatoi/main.aspx?ismenuclick=true&ctrl=inbox
// @grant none
// ==/UserScript==

(function() {
'use strict';
var read = $('');
$("#function_delete0").after(read);
var scriptElem = document.createElement('script');
scriptElem.innerHTML = 'function readAll(){var newMessages = document.getElementsByClassName("Row1_Bold");for(var i =0; i < newMessages.length; i++){var link = newMessages[i].getElementsByClassName("link");link[0].click();var backButton = document.getElementsByClassName("ui-button");for(var j = 0; j < backButton.lenght; j++){if(backButton[i].value == "Vissza"){backButton[i].click();}}}}';
document.body.appendChild(scriptElem);
})();

There is a "button" under the header, to hide it. Maybe NPU could make it more visible so nobody could miss it.

It should solve #67

GreaseMonkey 4 has some breaking changes, which need script fixes to become compatible. The old methods should be kept, too, to keep compatibility with Tampermonkey.

Adding the line
// @include https://*neptun*/*Hallgatoi*/*
would fix it.

These controls are missing in some cases:

The reason seems to be a bug in Neptun, which is not universally reproducible: as soon as certain users (even with NPU turned off!) change the number of items displayed using the dropdown in the header, the entire pager table vanishes (though the display does get applied to the subject list). The user who reported this only had 67 subjects in the list, so the bug might be related to not having enough subjects.

Ha kikapcsolom a scriptet be tudok lépni, és ha ezután benyomom a scriptet és újratöltöm az oldalt akkor teljesen jól működik az egész. 2-3 napja jelenhetett meg ez a probléma, korábban sose volt ezzel gond. Firefoxot használok.

[feature request]
After 2 semesters of my MSC, I still have to change the course from BSC at every login. Could NPU remember my last selected course and change to it automatically?

Sziasztok!

Bele tudnátok tenni kérlek a következő release-be, hogy ne csak a féléves indexsorok, hanem a speciális féléves indexsorok teljesült tételei, tárgyai esetén kapjanak zöld háttérszínt?
#h_markbook_gridSpecIndexEntry_bodytable tr.SubjectCompletedRow td {
background-color: #D5EFBA !important;
}

Várom a visszajelzéseteket, köszönettel:
Ákos

Please make an option to mark selected mails as read. It is very annoying that I have to open each mail separately, even if I've already read them in my emails. It's very hard to organize Neptun messages, I already have 44 unread, and when a teacher submits 30 exam dates by accident, I get 30 mail notifications (happened before). So this would be a very useful feature. Thanks!

Tampermonkey hibaüzenet: Limited runtime host permissions might break some Tampermonkey features like script update, GM_xmlhttpRequest and others!

Minden webhelyhez engedélyezve van az elérése, ennek ellenére nem tűnik el a hibaüzenet. Az összes funkció közül csak a beérkezett üzenetek elolvasását lehet mellőzni, a többi funkció nem működik.

ELTE Neptun

I looked into the issue and figured out some problems. Just as I said in #1 , the whole "How Neptun handles the filter listbox" thing must be totally overridden by NPU because when a filter happens, the whole listbox gets recreated - and if we use the listed exams as data for the filter, after the filtering, there will be only one subject, the currently filtered one, in the listbox.

What could be done is this: for every semester or filterExams change, scrape the list of subjects once and create the filtered listbox, then somehow use that, without allowing Neptun to recreate it!

Could you please elaborate the incosistencies you found in the filtering code?

Not sure if this is a universal issue, but on this version the classification is not working, because the grade names are different. Jeles (5); Jó (4); etc. instead of Jeles; Jó; etc. .
I quickly fixed it for myself like this:

if (grade.indexOf("(") > 0) {
    grade = grade.substr(0, grade.indexOf("("));
}

If it looks good I can make a PR.

Build: 452 (2017.11.08.) P20171221

The course registration ("kurzusfelvétel") menu is always filled with a lot of courses that I might not want to see for now.
I think the main reason of it is 1) you see subjects for all semesters at once, including ones that you can't even apply to, and 2) there are always some subjects that appear more than once in the list

Would it be possible to make modifications to the subject list to mitigate these annoyances?

For the first one, I was thinking if an additional filter could be added to the existing ones, with a dropdown menu having all the options (semesters 1-6 + an option for those with no semester set). Though it can be a problem if as the user progresses through semesters they may totally forget about earlier subjects, so it might be better to always include earlier semesters and those with a recommendation set.
Also, it might be even better if completed subjects could be filtered out too.

For the second one, it might be wiser to know why are they duplicated before just filtering the dupes out. Do you (or anyone reading this) have information on this?

If this is a lot of work, tell me and maybe I could try to do these myself, I was recently experimenting with userscripts anyways.. :D

With Vimium, navigation is easier because pressing f will generate jump keys which you can use to "click" on elements. For example, "clicking" the menu for "Personal data" brings the dropdown, after which f and another sequence can take you to the page.

Typing in f ea here:

will bring the menu down properly, after which another f renders the new set of keys:

Whereas doing f ga or f cc will immediately jump, because "Studies" is clicked.

However, this is broken by the fact that simply "clicking" on "Studies" will jump to the index, without pulling the dropdown, as the dropdown is only there on the hover action now.
This makes the jump to target feature of Vimium useless...

I'm not sure if one could reasonably detect from within NPU that a browser addon is installed/running, so a checkbox that disables these "shortcuts" (preferably off by default, because it's highly unlikely that non-IT people will use something like Vimium...).
Same applies for the "subjects" going to registration and "exams" going to registration, too.

The issue mentioned by me in #21 was not fixed by #22.

I have some exams already subscribed to, but the subject dropdown shows all but one in white, and only one in yellow.
(The subjects which don't have any exam posted are properly removed from the list.)

Hi!

Most szeretném elkezdeni használni a scriptet de nem egészen értem a readme alapján, hogy a Felturbózott szabad helyre várakozást-t pontosan, hogy is kellene használnom.

Van egy tárgy, annak három meghirdetett gyakorlata, mind a három fullos. Bejelöltem őket és eltároltam. Hogyan lesz ebből minél gyorsabb tárgyfelvétel ahogy ürül egy hely?

Előre is köszi a segítséget!

Hi,

Neptun powerup is not working. I had tampermonkey and neptun powerup script downloaded. Also, java is enabled, I don't know if that's important. I don't know if that could be an issue.

Thanks in advance!
Petra

User report:

Vizsgajelentkezés lapon zöld színnel (azaz teljesítettként) jelöli azokat a tárgyakat, amik korábban már fel voltak véve, azonban nem lettek teljesítve. Mivel automatikusan a Teljesített tárgyak elrejtése volt beállítva, majdnem lemaradtam a vizsgákról.

I'll try to repro in the meantime.

@whisperity Do you have an idea what's causing this?

1. Take an exam. Get a passing grade.
2. Because passing grade exists, the subject is marked completed, the hide filter filters all exams from it out.
3. Sign up for another exam from the same subject (with the intent of improving your grade)

After this, the exam you signed up for will be yellow, and the subject in the drop-down will be yellow. This is expected behaviour.

Other exams from this subject in particular which you did not sign up for will be either green (because completed) or no highlight at all. (I cannot confirm which happens because we have a Neptun shutdown for the weekend. Will confirm later, if neccessary). This isn't that much of a problem, the good thing is that the exam you are retaking is properly highlighted.

However, when someone clicks Filter completed subjects, the following happens:

• The exam rows from all completed subjects, including the one you are having a retake from, gets hidden.
• However, the subject itself from the drop-down list does NOT get hidden at all. If the user filters to this subject in particular, they will get an empty list.

I think the fact that someone is having an exam from a subject not yet taken should override the "completed" factor when it comes to filtering. So in this retake case, the completion filter should not filter out any of the remaining exam dates from said subject.

According to this video: https://www.youtube.com/watch?v=C_bvX1CvgNM&list=PLm3AdVwMMCqwkassnBLieCx7LGM0buK4Z&index=1
After today update elte's neptun site going to have a

• different login page
• a news site as default page after login, which requires an extra step to reach the actual neptun

Would it be acceptable adding elte specific changes to the NPU project ?
(I have access to ELTE Neptun, and can do test if needed)

Akárhogyan is próbálom használni,, mindig azt írja ki, hogy az adatok betöltése nem sikerült, pedig 2 napja még működött teljesen jól. BME neptunon btw

When the login timeout is reached and the user logs in again, it'd be nice if NPU could offer the option to open the last page instead of going to the home page.

On the OMHV reports page, the script constantly tries to load the list but there's nothing to choose from the dropdown (just the default text). The page reloads, then the script attempts to load it again, and so forth.

Build: 455 (2018.07.19.) P20181010

@solymosi Could you please apply the fix you did on the exam registration page to the "My exams" page too? (Route code 0402.) If an exam is registered but not yet graded (i.e. it has the yellow background), the [+] sign is hidden.

I downloaded Tampermonkey from the Mac App Store and installed NPU just like on any other browser and so far it seems to be working perfectly.