Comments (11)
The page size doesn’t matter, it’s slow even in bare app with no js/css
I use SvelteKit rn and I don’t have this issue in my app. Look at the video I posted above, this is how it works on an iPhone even on bare app. For some reason the route changing is slow on iPhone
from solid-router.
Here is the video of solid looking laggy even for the most basic view
https://github.com/solidjs/solid-router/assets/24430919/186fe747-700c-4696-81fd-78e482204545
from solid-router.
A reproduction would really help here, even if it does happen with 'any solid app with this router and links', I for example haven't experienced it in my apps. Could it be something to do with transitions causing page navigation to be delayed while waiting for stuff to load?
from solid-router.
I'm not sure about transitions but it's slow. For reproduction do "npm create solid@latest" and select basic template, add any routes and use
from solid-router.
Yeah hmm.. I'm not seeing it. Even with 6x CPU slowdown on desktop. It is possible there is some sort of performance thing. Maybe even platform specific. Do you see this same lag on: https://docs.solidjs.com/? This is a real site so there are other considerations there but I just want to sort of figure out where to narrow this down a bit because as Brendonovich says there are 1000s of sites out there using the router and this hasn't been reported before.
from solid-router.
I experience it on iOS
RPReplay_Final1708106344.mp4
RPReplay_Final1708106237.mp4
from solid-router.
Look how slow it is on Solid compared to Svelte
from solid-router.
Isn't this more related to network being slow and the routes being loaded lazily?
Maybe there is also a element in perception involved, since the nav on solid docs does close before the route is finished loading.
I noticed that the payload from the loaded route data in the svelte docs is like < 100B
(depending on the page of course) while the route data loaded in solid docs is more in the ~ 80kB
range.
@DoctorRyner did you have a look at the network tab (for size comparison) and while trying to throttle the network speed?
from solid-router.
Yeah hmm.. I'm not seeing it. Even with 6x CPU slowdown on desktop. It is possible there is some sort of performance thing. Maybe even platform specific. Do you see this same lag on: https://docs.solidjs.com/? This is a real site so there are other considerations there but I just want to sort of figure out where to narrow this down a bit because as Brendonovich says there are 1000s of sites out there using the router and this hasn't been reported before.
Hello @oddcelot @ryansolid ,
Have you consider to change Network throttling to Slow 3g and try switching between routes. There is no indicator that the page is loading and it looks like the page is frozen.
from solid-router.
It isn't fetching from network after loading them first time.
It is slow even on a macbook m1 / asahi, compared to svelte docs. But I think it's related to expressive-code
block being inited. As if you find parts that dont have many, and hide from active viewport, then it's fast, otherwise it's several hundred milliseconds, you can see the title change first and blink before the rest of the articles comes in (not from network), so whilst most people wouldn't consider that slow it's still odd. I think probably a docs issue
from solid-router.
@mattbdc nah, I first experienced it in my bare bone project, so it must be related to router
from solid-router.
Related Issues (20)
- <A> Component causes incorrect error message when used outside of a <Route /> HOT 3
- [Bug] MemoryRouter - `set()` can't change the page
- `useLocation().state` does not get updated on history back HOT 1
- [Bug?]: Unable to use `ErrorBoundary` when throwing Error from cached function in combination with `load` HOT 5
- action always trigger on form submit
- Slow performance matching route with localeCompare HOT 2
- Route load results in inconsistent revalidation behaviour HOT 2
- Why not just export useRouter and useRoute? HOT 2
- Error: <A> and 'use' router primitives can be only used inside a Route. HOT 3
- SSR no matching exports HOT 1
- location.state undefined with HashRouter on v0.13.3 HOT 4
- useIsRouting returning true from SSR and causing Suspense issues HOT 2
- HTML anchors with unicode id hash could not trigger page jump HOT 2
- A component isActive subpath match incorrect
- `useCurrentMatches` is not reactive
- Crash when server function throws redirect and wrapped in createAsync HOT 3
- `window.location` holds incorrect value on initial client-side render HOT 1
- Actions called in onMount (or first run effect) are destroyed by start process, and do not receive values nor errors HOT 4
- In the new version, Route is imported as a type rather than a method. HOT 3
- Returning `never` from `redirect` function makes incorrect behavior HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid-router.