Comments (3)
From what I can tell this is already being thrown as a normal error and not a crash - wrapping the <Show>
in an ErrorBoundary
functions as you'd expect.
Perhaps just a better error message is necessary?
from solid-router.
I think the issue here is that instead of handling the redirect, and navigating user to the new url, it throws an error. I don't think wrapping <Show>
in ErrorBoundary
will help.
From the docs it seems that only cache
and action
functions know how to correctly handle redirects. But I think there are cases, when we don't want to cache this function. For me it seems like missing functionality. We can try to use some workarounds, like cache revalidation, or pass some dummy random argument, so it will always produce unique cache key, but that doesn't seem as right thing to do.
from solid-router.
Yeah cache
and action
are the only wrappers that handle redirects, it's possible that a third neutral one is needed.
Even then a thrown response in a raw server function surfacing as an error is still expected behaviour, it could just be reported better.
Wrapping the <Show>
in ErrorBoundary
doesn't help, but it functions as you'd expect any other error to (repo) rather than causing a crash which would be more worrying.
from solid-router.
Related Issues (20)
- HTML anchors with unicode id hash could not trigger page jump HOT 2
- A component isActive subpath match incorrect
- `useCurrentMatches` is not reactive
- `window.location` holds incorrect value on initial client-side render HOT 1
- Actions called in onMount (or first run effect) are destroyed by start process, and do not receive values nor errors HOT 4
- In the new version, Route is imported as a type rather than a method. HOT 3
- Returning `never` from `redirect` function makes incorrect behavior HOT 5
- Absolute redirects inside `cache` are ignored if not called in `load`
- ErrorBoundary fallback renders twice HOT 2
- Drive letter is added to relative path on navigation when page is build on windows HOT 2
- NoJS mode is broken: initFromFlash cookie does not populate submission props HOT 1
- Ckeditor link trigger the router.
- Router fails to work properly on navigation HOT 2
- [Bug?]: submission.clear is not a function HOT 2
- Type issue: RouteLoadFunc generic cannot be inferred correctly
- Throwing or returning in redirect inside a cache function used in load results in error HOT 1
- Weird redirection when using Router and Route HOT 4
- 'use server' at top of file results in TypeError: action.apply is not a function HOT 3
- Solid Elements don't work with Server Actions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid-router.