Giter Club home page Giter Club logo

Comments (3)

Brendonovich avatar Brendonovich commented on July 4, 2024

From what I can tell this is already being thrown as a normal error and not a crash - wrapping the <Show> in an ErrorBoundary functions as you'd expect.
Perhaps just a better error message is necessary?

from solid-router.

maksimsemenov avatar maksimsemenov commented on July 4, 2024

I think the issue here is that instead of handling the redirect, and navigating user to the new url, it throws an error. I don't think wrapping <Show> in ErrorBoundary will help.

From the docs it seems that only cache and action functions know how to correctly handle redirects. But I think there are cases, when we don't want to cache this function. For me it seems like missing functionality. We can try to use some workarounds, like cache revalidation, or pass some dummy random argument, so it will always produce unique cache key, but that doesn't seem as right thing to do.

from solid-router.

Brendonovich avatar Brendonovich commented on July 4, 2024

Yeah cache and action are the only wrappers that handle redirects, it's possible that a third neutral one is needed.
Even then a thrown response in a raw server function surfacing as an error is still expected behaviour, it could just be reported better.
Wrapping the <Show> in ErrorBoundary doesn't help, but it functions as you'd expect any other error to (repo) rather than causing a crash which would be more worrying.

from solid-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.