Giter Club home page Giter Club logo

Comments (2)

rturnq avatar rturnq commented on May 26, 2024

I don't think this will quite work. The Route component actually just returns the props object which is then consumed by the Routes component. It isn't really a normal component, but more of a way to inject the route configuration leveraging the tree structure JSX children give us. All of the route components are evaluated before Routes renders so any route which returns a Navigate I would think would cause a navigation to occur immediately, regardless of if that route matches.

Route rendering on match occurs in the element or component defined on the Route, so it would be more appropriate to put the navigation in there. I think the easiest would be to just wrap another route around those you want authorized but you could also possibly encapsulate that as well. Something like (untested):

const AuthenticatedRoute = (props: AuthenticatedRouteProps) => {
  const [, rest] = splitProps(props, ["isAuthed", "path"]);
  return (
    <Route
      path={props.path}
      component={() => props.isAuthed ? <Outlet /> : <Navigate href="/login" />}
    >
      <Route {...rest as RouteProps} path="" />
    </Route>
  );
};

This would probably need to have some extra logic to handle paths which end in a *.

from solid-router.

kevineaton603 avatar kevineaton603 commented on May 26, 2024

New to solid.js and its ecosystem so I don't know how to leverage all the API's quite yet. But this definitely makes sense! Thank you for your help!

from solid-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.