solemnscribe / arduino-shot-timer Goto Github PK

Can you help me ?

In function 'convert_num', inlined from 'lcd_print.constprop' at sketch/LCDHelpers.h:75:16: sketch/LegibleTime.h:62:11: warning: 'strcpy' writing 13 bytes into a region of size 11 overflows the destination [-Wstringop-overflow=] strcpy(str,"000000000000"); // pre-set -- should this go in PROGMEM? ^ In function 'convert_time', inlined from 'lcd_print_time.constprop' at sketch/LCDHelpers.h:88:17: sketch/LegibleTime.h:96:11: warning: 'strcpy' writing 13 bytes into a region of size 11 overflows the destination [-Wstringop-overflow=] strcpy(str,"00:00:00.000"); //pre-set -- should this go in PROGMEM? ^

parTimes displays 40 possible times, but the array is initialized to a length of 10 - why?

When reviewing shots on an empty shot string, the interface allows scrolling from shot 0 to shot 1, even though there is no shot 1.

The interface should either not allow scrolling on an empty shot string and/or display a 'no shots!' message.

I am getting:

no matching function for call to 'MenuSystem::MenuSystem()'

When trying to compile.

Can you please include a physical connection schematic?

Code should have a consistent style for files/filenames, variable names, function names, etc, etc..

Google's CPP guide is controversial with respect to code standards, but fairly standard with respect to style:
https://google.github.io/styleguide/cppguide.html

In a hypothetical future with SD card support and the addition of a microphone jack to connect to electronic muffs...

.. it would be nice to be able to record a 'pre-string prompt' which would be played before the BEEP();

"Make ready! Stand by...."

And perhaps even terminating prompts.

"If you are finished, unload and show clear."

Or even... assign prompts to play at specific parTimes:

"2 on T1, 2 on T2! Then clear the plates!"

And then with a randomizer to select the message....

Dynamically generated courses of fire!

The original free RAM was very low
char startName[] = "[Start]";
char reviewName[] = "[Review]";
char parName[] = "Set Par >>";
char parSetName[] = "<< [Toggle Par]";
char parTimesName[] = "<< [Par Times]";
char settingsName[] = "Settings >>";
char setDelayName[] = "<< [Set Delay]";
char buzzerName[] = "<< [Buzzr Vol]";
char sensitivityName[] = "<< [Sensitivity]";
char echoName[] = "<< [Echo Reject]"; 

TO

const char PROGMEM startName[] = "[Start]";
const char PROGMEM reviewName[] = "[Review]";
const char PROGMEM parName[] = "Set Par >>";
const char PROGMEM parSetName[] = "<< [Toggle Par]";
const char PROGMEM parTimesName[] = "<< [Par Times]";
const char PROGMEM settingsName[] = "Settings >>";
const char PROGMEM setDelayName[] = "<< [Set Delay]";
const char PROGMEM buzzerName[] = "<< [Buzzr Vol]";
const char PROGMEM sensitivityName[] = "<< [Sensitivity]";
const char PROGMEM echoName[] = "<< [Echo Reject]"; 

Original issue reported on code.google.com by [email protected] on 4 Sep 2014 at 12:11

This is my test issue

• Task list 1
• Task list 2