solacecommunity / spring-solace-leader-election Goto Github PK

join-group shows warning in spring configuration

In a project I use several Binders e.g. spring.cloud.stream.binders.solace1. This does not work, The framework tries to connect with the default JCSMPProperties.
It would be nice to have a configuration where I can reference a special binder that is needed for the leader election.

new "join-groups" option "yieldOnShutdown" default: true

Runtime.getRuntime().addShutdownHook(new Thread(this::shutdownHook));

 private void shutdownHook() {
     LOG.info("Shutdown! Got to yield leadership {} ", yieldLeadershipInShutdownHook);
     solaceLeaderInitiator.yieldLeaderShip("publisher"); // Dirty, but ok
 }

because if other spring shutdown hooks like solace binder take time (up to X 100 ms)
This delays the failover.

Feature Description

the java version 11 is outdated and should be lifted at least to 17

Use Case

EOL Java 11

Proposed Solution

<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
or
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>

When using solace-java-spring-boot-starter in my application.
Than the leader start will use the same clientName and the connection will be reset by the broker.