sogggy / pe Goto Github PK

Coming soon section does not really have much details included. Perhaps if this were to be included, it should explain a bit on how the feature should look like (with mockups), or explanation on how it might work.

Not sure if this case should be covered, but the application's countdown delivery timings solely depends on the machine's clock in determining when it should deliver by.

Change to year 1992

Changed to year 2022

Delivery time has reduced significantly!

Perhaps integer overflow cases should be handled for indexes for commands such as add, edit etc.

Error message if there is overflow.

Error message if there is no overflow.

Even though they are both postive numbers, their error messages are different, which implies that overflow was not handled properly.

The examples given under inventory do not have the '-i' in them, which misleads users into inputting the wrong command.

When inputting a tag that is too long, user will be unable to see what the full name of his tag is.

When entering a timing that is extremely long, user is unable to even press enter, and there is also no error message that is given.

The errors are as of below, based on the numberings in the image:

1. 1 and 2: Index, EditItemDescriptor and EditDeliveryDescriptor should be showing solid diamonds instead, as they do not exist if the EditCommand classes do not exist.

2. 3 and 4: These classes are extending the abstract classes, so should not be using the 'implements' hollow triangle and dotted lines.

For the first circled user story, the benefit can be clearer as input more details do not really elaborate on what details or what benefit it brings to be able to do so.

For the second circled user story, it does not explain the benefit to the user but to the developer.

Logic Architecture Diagram is so complex that it is quite unreadable.

If intended to put in as metric, perhaps there should be a limitation to what kind of metrics can be input, as the following input is not a valid metric, but is allowed in the app.

When adding a phone number that is extremely long, we cannot see the phone number field anymore.

Using the add command example as given in the command summary, I am unable to add an inventory using the command line.

As circled, app says that it is an unknown command.

Sentence grammatical error in this section of the UG

App is still using AB3's logo.

Errors as circled:

1. Is adding description like this to explain what happens allowed in sequence diagrams? Perhaps it should be some form of method call instead
2. Not sure where did the result variable came from

After using find, the undo/redo commands does not have any visual updates to the user that the state has been reverted, if a 'find' command that does not find anything was used.

After redoing, still cannot see anything visual updates.

Such a behaviour should perhaps be specified in the user guide, which is not, from what I see!

Errors as listed based on numbering on image:

1. Parser is named addressbookparser
   2., 3., 4. : Return arrows are not dotted

2. the parameter inside execute is capitalised, which is not the convention of naming an object.

As a user, the glossary might be a little too concised. I may not understand terms in the UG such as GUI, java SE platform etc, and will need the glossary to help me understand.

When opening the application, there is a big white space below that I cannot remove when using the application, even after I reopen it.

This might be an issue, but an activity diagram should be explaining at a high level what is happening when user executes a command. However, this activity diagram currently contains too many implementation details.

Perhaps there can be better error messages given by the application when inputting wrong parameters, such as invalid indexes.

When index is either negative or exceeded, both just says invalid, which is unclear.

In the last screenshot, the command format is correct, but it says that the command format is wrong.

Architecture Sequence diagram is not updated. Still mentions 'saveAddressBook(addressBook)'.