softwareengineeringdaily / sedaily-front-end Goto Github PK

Most likely flow since that's what the backend is likely to be using. I don't think we HAVE to keep it consistent but it's probably wiser to keep the same system for both repos.

Also should tie into Heroku deployments

Specially for vue / actions

Should include a prompt when commenting.. to require name, email, username fields.

After an episode you could take a short multiple choice quiz to test your understanding of the concepts.

You could get karma based off of this.

Similar to banks, etc.

I believe Vue has a few helper functions / patterns to not have code like this:

  computed: {
     postId () {
        return this.$store.state.items[this.$route.params.id]
      }
 }

No indicator that comment is still processing currently. Should also not show alert on failure but a nicer message inline with the fake comment, maybe even a "Retry" button.

Note, make sure to handle multiple dummy comments correctly.

Similar to soundcloud, etc.

..

Fix:

Uncaught (in promise) TypeError: Cannot read property 'token' of undefined

Part of an item view. Requires further exploration of moment docs

From Slack SWXY:

every episode happens to be linking to https://sedaily.herokuapp.com/#/item/undefined right now, think u changed the datamodel and didnt update this frontend

Would be nice if we could reuse joi and have something like this:

  email: Joi.string().email('Please make sure you provide a valid email').required('Please make sure to provide an email')

Possibly not working when logged out
http://localhost:8080/#/item/59a34f083291786fb78ed38a

Currently just a list:

Height is wrong.
display: flex should be applied to items holder

@crablar mentioned this happens to him often when developing

Could be due to the nature of live code reloading while developing? Haven't really noticed this as an issue.

This will give us a full staging environment.

Seems that if the token is invalid user stays logged in.

[ ] Maybe require as part of linter

i.e take a look at SeleniumHQ repos.

For someone wanting to contribute - I think a CONTRIBUTING file that explains the repo's workflow process and the different branches would be helpful.

Specifically, it seems mvp is the active branch but what is the role of master then. And which is being deployed to https://sedaily.herokuapp.com/#/ ? It's not the same as where mvp is right now but it's hard to tell if it's master because that's not working locally (for me at least, mvp is, however).

Also are there expectations around tests or any other conventions not otherwise obvious?

I'm willing to write it up based on discussion here from main contributors.

Now we are using Selenium

Since that's what the backend is using + nicer integration into current build tools (I assume)

Maybe cap the heights and clean up the css (maybe replace image with a svg / code version)