softek / puppet-zabbixagent Goto Github PK

With three different flavors of supported operation systems, it is past due to add rpec-puppet tests. As this module become more complex, it is important that there is verification of the module via tests. This will also aid in verifying contributions are correct without too much effort.

These tests can later be automated with Travis CI.

There is no dependency relationship between the Service resource and the Ini_setting resources. When an ini_setting resource changes, it should notify the Service resource.

I have almost clean ubuntu 12.04 system managed remotely by puppet-agent.
With the initial configuration I have noticed the following problem in the log file

zabbix_agentd [23172]: cannot create PID file 
[/var/run/zabbix/zabbix_agentd.pid]: [2] No such file or directory

There is no /var/run/zabbix, but /var/run/zabbix-agent folder were created instead.
So, when perform this change in /etc/puppet/modules/zabbixagent/templates/zabbix_agentd.conf.unix.erb

+ PidFile=/var/run/zabbix-agent/zabbix_agentd.pid
- PidFile=/var/run/zabbix/zabbix_agentd.pid //Deleted

everything goes fine.

Just for information purposes I present my current puppet declaration (on puppet-master)

node 'metrics-fe1' {
 # - Ensure correctness of APT configuration -------------
 class { 'apt':
    proxy_port  => '3128',
    proxy_host  => 'proxy.metrics',
 }
 # - Add ppa with latest zabbix-agent
 apt::ppa { "ppa:h.tims/upstream-experimental": }

 # - Install all required packages --------------
 $base_packages = ['ntp'] # tried  ['ntp', zabbix-agent'] for the first time...,
 # ... but confict with zabbixagent below with message ' Duplicate declaration: Package[zabbix-agent] is already declared in file /etc/puppet/manifests/site.pp at line XX; cannot redeclare on node'

 package { $base_packages:
    ensure => installed,
 }
 class { 'zabbixagent':
    servers => 'zabbix-master.metrics',
 }
}