socialpandas / sidekiq-priority Goto Github PK

I am trying to find a gem that will allow me to combine prioritization in Sidekiq with scheduling.

Sidekiq currently has a perform_at method that allows me to set a certain time for a job, but if two jobs are scheduled for the same time, which wins?

I am trying to do something like:

AnnouncementScheduler.perform_with_priority_at(:low, " 2016-07-08 08:34:53 -0400", a.id)
AnnouncementScheduler.perform_with_priority_at(:very_high, " 2016-07-08 08:34:53 -0400", b.id)

where the scheduling conflict would resolve in favor of the second one, due to priority.

I just wondered if your gem already does this, as I don't see anything for that in the documentation, but often miss things.

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

I am trying to use the gem but have an error regarding celluloid when trying to start sidekiq as you can see in the image:

The celluloid seems to be require in this file:
sidekiq-priority/lib/sidekiq/priority/server/fetch.rb

However I do not understand why it is require?
It seems to be working when removing the line:
https://github.com/socialpandas/sidekiq-priority/blob/master/lib/sidekiq/priority/server/fetch.rb#L1

I wonder if this is still needed?

Thanks for your help.

There's an interaction issue with sidekiq-throttler.

Sidekiq throttler works by scheduling anything beyond a certain threshold in the next window of time as defined by a period option defined in sidekiq configs.

However, scheduled jobs (when unscheduled) fail to go to the correct 'priority' queue & instead go to the default queue.

I think that the correct way to handle this is to change the queue on the job before calling 'client_push' in worker_ext.rb, but I need to look more closely at it. I'm reporting the issue to invite anyone else to do the same.