Giter Club home page Giter Club logo

scc-multiapi-converter's Issues

[Repo Improvement] Associate GitHub actions to PR tags

When a pull request is merged into main:

  • If it has the documentation tag, the wiki should be updated.
  • If it has the release tag, a new release should be generated.

Adding both tags results in both actions being executed, and it would also be possible to merge without adding any of the two tags.

[SCC-MultiApi-Converter] Update actions to avoid errors with forks

As a developer, I want the actions that are defined for the project to work with the forked repositories as well, so people can contribute with the project and don't receive an error from the actions.

Now, maven-pr action searchs for the HEAD commit reference inside the same repository and branch, and executes the jobs on that. This makes impossible the use of forked repos, so we need to address it.

Also, if this is possible, we must remove the execution of this action on push to main branch.

When this problem is solved, we must spread the solution to another projects with the same problem.

Failed to execute goal 'generateTests' while trying to generate contracts from an OpenApi yaml document

Hello,

I would like to understand how this library works. So I created a Spring-Boot project based on Spring-Boot 2.7.3 and Spring-Cloud 2021.0.3. As build tool I use Maven 3.8 and to configure the project properly I followed the instructions on your website. As API definition I used the OpenApi example from your website.

When I run the build I get the following error message:

Failed to execute goal org.springframework.cloud:spring-cloud-contract-maven-plugin:3.1.3:generateTests (default-generateTests) on project openapi-scc: Execution default-generateTests of goal org. springframework.cloud:spring-cloud-contract-maven-plugin:3.1.3:generateTests failed: Failed to convert file [C:\opt\ws\work\_openapi-scc\src\main\resources\api\openapi.yml]: Cannot invoke "io.swagger.v3.oas.models.media.Schema.getExample()" because "schema" is null -> [Help 1].

Am I doing something wrong? Is the example missing some things? Is the library having a bug?

The project where I had the problem can be found here:
https://github.com/ingogriebsch/_openapi-scc

[SCC-MultiApi-Converter] Add action check to ensure version is updated

As a developer, I want to have a check for the pom.xml version, to avoid errors during deployment stage.

We must analyze how to add a check for the version on PR, maybe including a new job/step on an existent workflow, or maybe adding a new workflow. This must check if the version is updated compared to the main branch, and if it's not, put a message on the PR including a link to the versioning system we are using, SemVer, so the contributor could solve the error.

When this problem is solved, we must spread the solution to another projects with the same problem, SCS Multiapi Plugin and KLoadGen.

[SCC-MultiApi-Plugin][OpenApi] Add support for parameters in Path Object

As of right now, SCC MultiApi Plugin only supports parameters in Operations.

We should develop a way to map the Parameters from the Path Object as well.

Here is an example of a parameter in a Path Object:
image

We should refactor the processRequest method in the OpenApiContractConverter to allow the usage of parameters in the PathObject

image

#3 Add License and create github actions for releases

In this issue we have to prepare everything related to release the plugin into Maven and have the correct github actions ready for the github release as well.

We need the following:

  • Add the MPL header in every java file.
  • Add the github actions folder and the necessary files for the release

[SCC-Multiapi-Converter] [OpenApi] Add the possibility of using referenced arrays with $ref Objects inside

Currently, SCC MultiApi does not support the creation of a contract when an array is referenced in a schema and has $ref inside of his items.

This happens inside the processBodyAndMatchers method because we check if the Schema has properties, but an array doesn´t, it has items. As you can see in line 199:

image

Check OpenApi Docs for this issue: https://swagger.io/docs/specification/data-models/data-types/

image

[SCC-MultiApi-Converter][OpenApi] Rewrite the logic for AnyOfs

As of right now, the logic behind the AnyOfs will create a N number of contracts that will come from the AnyOf´s list.

This creates a problem since the N number and the contract can changed based on the execution of the plugin, making it a lottery for a user to get the right contract at the right time.

As a team, we must review the logic behind this and change it to a behaviour that is manageable for a user.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.