snapzie / teacozy Goto Github PK

overall

Great work! Your project shows a lot of well executed code and attention to detail. You should feel proud of the work you've put in.

HTML/CSS

I think your HTML looks excellent. In addition to good use of divs and encapsulation, I liked your white spacing between elements. When coming up with class/id names, make sure they're descriptive enough where you'll know immediately what their purpose is, (never worry about being too explicit with your naming for classes and ids).

Your CSS also shows a lot of good decisions. I like your use of multiple selectors to keep your code DRY (don't repeat yourself), like this:

a, h2, h3, h4, h5 {
  color: seashell;
}

In the above example to do you think your work would benefit from a class that applied to all of those headers? Why/why not? And are there any other opportunities in your code to chain together classes like this?

I notice you use a pixels to define your element sizes. Like this:

.text h2 {
  margin-top: 10px;
}

.text h4 {
  margin-bottom: 10px
}

While this is an effective strategy and a good use of a new concept, can you think of when you might want to use percentages to define those sizes? If you haven't worked with percentages yet, now would be a good time to do a little poking around and see what you can find out about them.

And so...

Excellent job and keep up the good work!