snapchip / unity-outline Goto Github PK

The 'draw on top' option works fine EXCEPT when Unity does a 'CopyDepth' pass.

For example with these setting (depth texture enabled and MSAA off)

Then the 'draw on top' option does not work, the outlines will always be on top. This only happens in the game view.

When MSAA is enabled, the issue is not there or when the depth texture is disabled and post processing is also disabled on the camera, it's also fine.

I did some research and found that whether or not the 'draw on top' option works, is related to whether or not Unity does a 'CopyDepth' pass. The pass is here.

https://github.com/Unity-Technologies/Graphics/blob/716e8e06a2ba235052572dff41b98074e6065dee/com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

And here in this script

https://github.com/Unity-Technologies/Graphics/blob/716e8e06a2ba235052572dff41b98074e6065dee/com.unity.render-pipelines.universal/Runtime/ForwardRenderer.cs

you see they do some logic like this

bool requiresDepthPrepass = requiresDepthTexture && !CanCopyDepth(ref renderingData.cameraData); requiresDepthPrepass |= isSceneViewCamera; requiresDepthPrepass |= isPreviewCamera; requiresDepthPrepass |= renderPassInputs.requiresDepthPrepass; requiresDepthPrepass |= renderPassInputs.requiresNormalsTexture;

which corressponds to the issue not being active when the scene view is active or when unity can't copy depth. So when unity does a deph prepass instead of the copy depth pass, all works fine..

Hi,
I like to thank you for this amazing shader!
I like to ask you if it is possible to add more than one render feature?
I've added 2 Outline Features with differend layers. But only the first in the list is drawn.
Any ideas?
Thanks in advance