smihir / samfs Goto Github PK

Steps to reproduce:

• mount samfs on a client
• create a file, and open it using vi
• every time we open the file, write something to it and then close

One observation is that the file does not close until we force close it(:wq!).
Another observation is that if you repeat the above steps 4-5 times, the server starts misbehaving
with the following logs:

I1016 20:16:56.873904    6711 server.go:99] received lookup request for "checkaa"
I1016 20:16:56.874179    6711 server.go:134] received GetAttr request for "/checkaa"
I1016 20:16:56.875185    6711 server.go:99] received lookup request for "checkaa"
I1016 20:16:56.875377    6711 server.go:134] received GetAttr request for "/checkaa"
E1016 20:16:56.875394    6711 server.go:154] could not get open file ser/checkaa :: too many open files
E1016 20:16:56.875401    6711 server.go:149] unable to close file ser/checkaa :: bad file descriptor
I1016 20:16:56.875663    6711 server.go:99] received lookup request for "checkaa"
E1016 20:16:56.875895    6711 server.go:468] failed to get inode and generation number for / :: bad file descriptor
E1016 20:16:56.875903    6711 server.go:104] bad file descriptor

Maybe we are opening too many files and not closing them in the server. Which may trigger the issue as indicated by the logs. However, I am not very sure what is causing the problem. We may need to spend some more time to understand and fix this.

When running the following command:
./bin/write_tests -dir ../mountcli1/write_tests

It gives the following error:
E1026 19:40:01.251788 26697 main.go:43] failed to open ../mountcli1/write-tests/16.txt :: open ../mountcli1/write-tests/16.txt: no such file or directory

To make it run, ./bin/write_tests -dir ../mountcli1/ has to be written in the cmd prompt and then tab has to be pressed so that getattr is sent and then the initial cmd runs properly.