Giter Club home page Giter Club logo

muzakbot's Introduction

muzakbot's People

Contributors

dependabot[bot] avatar smalls1652 avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar

muzakbot's Issues

GeniusService crashes on startup on v2.3.5

What kind of bug is this?

Crash

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

The GeniusService process is crashing at startup with v2.3.5 due to an issue with the Azure Storage package. I didn't capture any logs at the time, but I did notice it when deploying it. Rolling the container image tag back to v2.3.4 "resolved" the issue and shouldn't cause any issues with the other pieces running on v2.3.5.

Will post more later when I figure out more.

Logs (Optional)

No response

[Update]: Switch to source generated logging

What kind of change is this?

Change/Update

What's the description of the change?

Need to switch to source generated logging to:

  1. Slightly improve performance.
  2. Make the log messages into templates, so it's easier to maintain.

What are the proposed changes that need to be made?

The following issues will need to be taken care of:

Find song/album doesn’t properly error out

What kind of bug is this?

Never responded

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

Whenever an issue happens with /findsong and /findalbum, MuzakBot doesn’t respond and it just continuously shows "MuzakBot is thinking…".

Seems to be happening very early on in the process.

Logs (Optional)

No response

[Update]: Switch to source generated logging (Handlers)

What kind of change is this?

Change/Update

What's the description of the change?

This issue is to track progress on #55 and cover classes in the MuzakBot.App.Handlers namespace.

What are the proposed changes that need to be made?

The following classes will need to be updated:

  • ArtistAlbumSearchAutoCompleteHandler
  • ArtistNameSearchAutoCompleteHandler
  • ArtistSearchAutoCompleteHandler
  • ArtistSongNameSearchAutoCompleteHandler
  • ArtistSongSearchAutoCompleteHandler

[Bug report]: Fix nullability of properties for iTunes API classes

What kind of bug is this?

Other (Provide below)

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

Multiple properties in the MuzakBot.App.Models.ITunes namespace should either be declared as nullable or explicitly defined as a being non-nullable.

Logs (Optional)

Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(8,19): warning CS8618: Non-nullable property 'WrapperType' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(11,19): warning CS8618: Non-nullable property 'Kind' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(23,19): warning CS8618: Non-nullable property 'ArtistName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(26,19): warning CS8618: Non-nullable property 'CollectionName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(29,19): warning CS8618: Non-nullable property 'TrackName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(32,19): warning CS8618: Non-nullable property 'CollectionCensoredName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(35,19): warning CS8618: Non-nullable property 'TrackCensoredName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(38,19): warning CS8618: Non-nullable property 'ArtistViewUrl' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(41,19): warning CS8618: Non-nullable property 'CollectionViewUrl' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(44,19): warning CS8618: Non-nullable property 'TrackViewUrl' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(47,19): warning CS8618: Non-nullable property 'PreviewUrl' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(50,19): warning CS8618: Non-nullable property 'ArtworkUrl30' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(53,19): warning CS8618: Non-nullable property 'ArtworkUrl60' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(56,19): warning CS8618: Non-nullable property 'ArtworkUrl100' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(68,19): warning CS8618: Non-nullable property 'CollectionExplicitness' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(71,19): warning CS8618: Non-nullable property 'TrackExplicitness' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(89,19): warning CS8618: Non-nullable property 'Country' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(92,19): warning CS8618: Non-nullable property 'Currency' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]
Warning: /home/runner/work/MuzakBot/MuzakBot/src/App/Models/ITunes/SongItem.cs(95,19): warning CS8618: Non-nullable property 'PrimaryGenreName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/MuzakBot/MuzakBot/src/App/App.csproj]

[Bug report]: Type mismatch with Bandcamp entities in Odesli API output

What kind of bug is this?

Unexpected behavior

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

There's a type mismatch in the Odesli API output when an entity for an album/song is found on Bandcamp. Typically the ID property for an entity is a string; however, here lately, the Odesli API has been returning those Bandcamp entities' ID as a number.

This causes the bot to return an error response.

Logs (Optional)

The JSON value could not be converted to System.String. Path: $.entitiesByUniqueId.BANDCAMP_ALBUM::3807726748.id | LineNumber: 0 | BytePositionInLine: 176. Cannot get the value of a token type 'Number' as a string.

[Update]: Switch to source generated logging (Modules)

What kind of change is this?

Change/Update

What's the description of the change?

This issue is to track progress on #55 and cover classes in the MuzakBot.App.Modules namespace.

What are the proposed changes that need to be made?

The following classes will need to be updated:

  • ShareMusicCommandModule
  • AdminCommandModule
  • LyricsAnalyzerCommandModule

[Feature]: Lyrics analyzer

What kind of change is this?

Addition

What's the description of the change?

I've been thinking about adding a new command that utilizes OpenAI's GPT-4 for analyzing the lyrics of a song and generating it's own interpretation of the lyrics. It's one of those useful use-cases I've found for ChatGPT. I personally don't take it as the "end all, be all" definitive interpretation of lyrics, but it has been very useful getting a general idea for what the lyrics in a song could potentially mean.

What are the proposed changes that need to be made?

There will need to be some things added in to make this work:

  • Implement calling the OpenAI API.
  • Implement "rate limiting" for how many times a user can run it daily.
    • Will probably have to setup a database to store that state?

[Update]: Switch to source generated logging (Services)

What kind of change is this?

Change/Update

What's the description of the change?

This issue is to track progress on #55 and cover classes in the MuzakBot.App.Services namespace.

What are the proposed changes that need to be made?

The following classes will need to be updated:

  • ItunesApiService
  • OpenAiService
  • MusicBrainzService
  • OdesliService
  • CosmosDbService
  • DiscordService
  • GeniusApiService

[Update]: Switch to source generated logging (Metrics)

What kind of change is this?

Change/Update

What's the description of the change?

This issue is to track progress on #55 and cover classes in the Metrics namespace.

What are the proposed changes that need to be made?

The following classes will need to be updated:

  • CommandMetrics
  • RequestDuration

[Bug report]: Lyrics analyzer rate limit is broken

What kind of bug is this?

Unexpected behavior

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

The logic for lyrics analyzer's rate limiting seems to be broken, but it's spotty for some reason. Whenever a user reaches the max rate limit for the day, there's a high chance that the database will return nothing and will trigger generating a new entry for the user.

Not sure why it's doing that and why it's spotty.

Logs (Optional)

No response

[Feature]: Define lyrics analyzer prompts in the database

What kind of change is this?

Change/Update

What's the description of the change?

Should probably move the lyrics analyzer GPT prompts to the database to make it easier to add and update the different styles without publishing a new version.

What are the proposed changes that need to be made?

No response

[Bug report]: Slash commands don't work in a DM to the bot

What kind of bug is this?

Unexpected behavior

If you selected "Other" in the previous section, what kind of bug is it?

N/A

Describe the bug.

This has been a long-standing issue. Whenever a slash command (/sharemusic, /lyricsanalyzer, etc) is sent as a direct message to the bot, it immediately responds with a "The application did not respond..." error.

I'm not entirely sure why. It should just work, but for some reason it's not.

Logs (Optional)

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.