small25 / mini Goto Github PK

I went back to use leveled 1.22 which seems enabled rtti by default.

Originally posted by @luguoxiang in google/leveldb#731 (comment)

We can do the same thing here right?

        def auth_headers
          @auth_headers ||= Utils::AuthHeadersFinder.new(credentials).auth_headers(maven_repo_url)
        end

Originally posted by @jurre in dependabot/dependabot-core#3403 (comment)

@luguoxiang
I have the same problem as you. And my code uses a lot of typeid, so I can't do as @muffinrecon said:

Separating the comparator into its own cpp file and compiling with the -fno-rtti flag worked best for me.

My only way is to enable rtti for leveldb. What did you do in the end?

Originally posted by @vermorth in google/leveldb#731 (comment)

It actually turns out it was the tests not being thorough enough, since it only tested with a single defined maven_repository at the time. With multiple repositories defined, several requests will be made, with different maven_repo_urls. I have added tests and reverted the change on the gradle version_finder.rb.

Originally posted by @gringostar in dependabot/dependabot-core#3403 (comment)

Can we memoize the result of the finder instead of the finder itself? I'm assuming it doesn't change for the lifespan of this object?

Originally posted by @jurre in dependabot/dependabot-core#3403 (comment)

__Originally posted by @Small25 in #1

Hello,
I know that there are certain issues with the Mac OSX and their version of the GCC compiler. I did install the Gnu GCC, but all the recommended methods of convincing OSX to use the Gnu compiler have failed.

I tried to install plyvel with pip and got fail messages. This is what I get - at least the essential bit.

Complete output (16 lines): running install running build running build_py creating build creating build/lib.macosx-10.6-intel-3.7 creating build/lib.macosx-10.6-intel-3.7/plyvel copying plyvel/_version.py -> build/lib.macosx-10.6-intel-3.7/plyvel copying plyvel/__init__.py -> build/lib.macosx-10.6-intel-3.7/plyvel running build_ext building 'plyvel._plyvel' extension creating build/temp.macosx-10.6-intel-3.7 creating build/temp.macosx-10.6-intel-3.7/plyvel gcc -fno-strict-aliasing -Wsign-compare -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -arch i386 -arch x86_64 -g -I/Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m -c plyvel/_plyvel.cpp -o build/temp.macosx-10.6-intel-3.7/plyvel/_plyvel.o -Wall -g -x c++ -std=c++11 -stdlib=libc++ clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later) clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later) error: command 'gcc' failed with exit status 1 ----------------------------------------

I obviously have an OSX later than 10.7, but for some reason this is not recognised.
I would be very grateful for any help concerning this issue.

Best
Pia

Originally posted by @PiPinoccio in wbolster/plyvel#114

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Originally posted by @WELCOME in github/docs#5875 (comment)

This issue appears to have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!

Originally posted by @docubot in github/docs#5875 (comment)

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Additional information

Originally posted by @0612346520 in github/docs#5875

I use cmake to build leveldb with my project,

add_subdirectory(leveldb)
target_link_libraries( ${APP_EXEC}  ...leveldb )

It seems leveldb disable RTTI (-f no-rtti) by default, there is some other third party library in my project which requires RTTI, is there any way to enable RTTI without modify leveldb/CMakeList.txt?

Originally posted by @luguoxiang in google/leveldb#731

Does your other third party library need to dynamically determine the type of the leveldb objects in include/leveldb, or for other objects? If not the you should be OK to leave RTTI disabled for leveldb, but enable it for other code. However, if you really do need RTTI enabled for leveldb then I think you will need to modify CMakeLists.txt as it is hard-coded to be disabled. I'm not a CMake expert, so there may be some environment variable that can modify CMAKE_CXX_FLAGS.

Originally posted by @cmumford in google/leveldb#731 (comment)

In dependabot/dependabot-core#3403 we added a dependency on dependabot-maven from the dependabot-gradle gem.
To ensure that the dependabot-maven gem is installed when we install the dependabot-gradle gem we need to declare dependabot-maven as a runtime dependency.

Originally posted by @xlgmokha in dependabot/dependabot-core#3477

It seems leveldb::Comparator does not work when RTTI disabled for leveldb and mycode is rtti enabled: https://stackoverflow.com/questions/57670944/undefined-symbols-for-architecture-x86-64-typeinfo-for-leveldbcomparator, is there any way to fix this issue while leaving my code rtti enabled?

Originally posted by @luguoxiang in google/leveldb#731 (comment)

I use cmake to build leveldb with my project,

add_subdirectory(leveldb)
target_link_libraries( ${APP_EXEC}  ...leveldb )

It seems leveldb disable RTTI (-f no-rtti) by default, there is some other third party library in my project which requires RTTI, is there any way to enable RTTI without modify leveldb/CMakeList.txt?

Originally posted by @luguoxiang in google/leveldb#731

This issue appears to have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!

Originally posted by @docubot in github/docs#5875 (comment)

#5870

Originally posted by @0612346520 in github/docs#5875 (comment)

I use cmake to build leveldb with my project,

add_subdirectory(leveldb)
target_link_libraries( ${APP_EXEC}  ...leveldb )

It seems leveldb disable RTTI (-f no-rtti) by default, there is some other third party library in my project which requires RTTI, is there any way to enable RTTI without modify leveldb/CMakeList.txt?

Originally posted by @luguoxiang in google/leveldb#731

Originally posted by @Small25 in #6

In dependabot/dependabot-core#3403 we added a dependency on dependabot-maven from the dependabot-gradle gem.
To ensure that the dependabot-maven gem is installed when we install the dependabot-gradle gem we need to declare dependabot-maven as a runtime dependency.

Originally posted by @xlgmokha in dependabot/dependabot-core#3477

Originally posted by @Small25 in #24

I was wrong 😑 The change have been made.

Originally posted by @gringostar in dependabot/dependabot-core#3403 (comment)

Originally posted by @Small25 in #3

@luguoxiang

Separating the comparator into its own cpp file and compiling with the -fno-rtti flag worked best for me.

Originally posted by @muffinrecon in google/leveldb#731 (comment)