skywinder / actionsheetpicker-3.0 Goto Github PK

Hi Everyone,
when I'm using this picker on iphone 4 (and only on real device) I've this bug. If I try the same code on the Iphone 3,5 inch simulator it works well...
What it can be?
Thank you so much, best regards!

Hi guys, thank for your project. Now I am facing a problem, I still want to be able to support ios 6 and xcode 5 helps me to test apps in ios 6 simulator. Unfortunately, your last changes cause compilation error in xcode 5.
in AbstractActionSheetPicker.m
if (floor(NSFoundationVersionNumber) <= NSFoundationVersionNumber_iOS_7_1) { - xcode 5 has no NSFoundationVersionNumber_iOS_7_1.
Can you redesign the comparison? Am able to do it by myself in my code, but everytime I run pod install, the code gets overwritten

I have seen plenty of examples in your sample project detailing how to customize buttons over the picker but there aren't any examples showing how to change the font of the data row in the action sheet. Any help is highly appreciated.

Thanks,
Jack.

In the new update to support iOS 8 compatibility ActionSheetPicker doesn't work correctly (it's basically unusable) in landscape in iOS7 (I haven't checked iOS 6).

this is really important, why would actionsheetstringpicker have it but not this one?

See screenshot below:

Thanks for saving me so much time. This is great work.

The measurement picker doesn't work well with imperial units. I am using this for a health application and users can choose their height. Unfortunately they end up with three columns in the picker: feet, first digit of inches, and second digit of inches. The first digit of inches is either a 0 or a 1.

Ideally, there would be a boolean for separating digits, or don't separate digits if the range is less than 30 or something.

I cloned a fresh version of the repo (October 8, 2014), made no changes and ran the ActionSheetPicker example. I get the following crash if I click the "Modal Test" button:

2014-10-08 17:45:15.042 ActionSheetPicker[8950:1362181] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Pushing a navigation controller is not supported'
*** First throw call stack:
(
    0   CoreFoundation                      0x000000010be5d3f5 __exceptionPreprocess + 165
    1   libobjc.A.dylib                     0x000000010a8b5bb7 objc_exception_throw + 45
    2   UIKit                               0x000000010929b617 __71-[UINavigationController pushViewController:transition:forceImmediate:]_block_invoke + 0
    3   UIKit                               0x000000010929aca1 -[UINavigationController pushViewController:animated:] + 571
    4   UIKit                               0x00000001091469ee -[UIApplication sendAction:to:from:forEvent:] + 75
    5   UIKit                               0x000000010924cbd0 -[UIControl _sendActionsForEvents:withEvent:] + 467
    6   UIKit                               0x000000010924bf9f -[UIControl touchesEnded:withEvent:] + 522
    7   UIKit                               0x00000001094f0c30 _UIGestureRecognizerUpdate + 9487
    8   UIKit                               0x000000010918c0a6 -[UIWindow _sendGesturesForEvent:] + 1041
    9   UIKit                               0x000000010918ccd3 -[UIWindow sendEvent:] + 667
    10  UIKit                               0x0000000109159ae1 -[UIApplication sendEvent:] + 246
    11  UIKit                               0x0000000109166bad _UIApplicationHandleEventFromQueueEvent + 17370
    12  UIKit                               0x0000000109142233 _UIApplicationHandleEventQueue + 1961
    13  CoreFoundation                      0x000000010bd92ad1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
    14  CoreFoundation                      0x000000010bd8899d __CFRunLoopDoSources0 + 269
    15  CoreFoundation                      0x000000010bd87fd4 __CFRunLoopRun + 868
    16  CoreFoundation                      0x000000010bd87a06 CFRunLoopRunSpecific + 470
    17  GraphicsServices                    0x000000010bab89f0 GSEventRunModal + 161
    18  UIKit                               0x0000000109145550 UIApplicationMain + 1282
    19  ActionSheetPicker                   0x0000000109097a23 main + 115
    20  libdyld.dylib                       0x000000010fc9d145 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

I've never used storyboards (in my apps I manage the transitions in code). Any ideas what I should do to make fix the example?

Please add a method to hide picker by request.

when both portrait mode and upside down portrait mode are enabled on my app, on the iPhone 4S device (as well as the emulator), the upside down portrait mode actually displays the action sheet picker
in the wrong orientation, so that it appears upside down, with respect to the rest of the app.

The date time picker shows up when clicked on a button in a tableview cell. when selected a date, the picker disappeared and everything got frozen. touching and clicking did not work on the screen.

any ideas?

Hey there,
I tried to run this together with a UITableViewCell (didSelectRowAtIndexPath). This is not possible since I get an NSInternalInconsistencyException with the reason "Invalid origin provided to ActionSheetPicker". Is there a way to run this project with a UITableViewCell?

I'd like to change the font color of the text on the picker "Cancel" and "Done" buttons. How can they be changed directly.

My application typically has black menus with white text on the menu.

I'm calling the following:

[ActionSheetStringPicker showPickerWithTitle:@"A-Trapezoidal (A-Trap)" rows:self.atrapNamesArray initialSelection:0 target:self successAction:@selector(atrapWasSelected:element:) cancelAction:@selector(actionPickerCancelled:) origin:self.view];

I do have a workaround by calling this line of code, but it causes havoc elsewhere inside my app. i end up putting this in multiple locations and switching the UIColor to do it.

UIBarButtonItem *barButtonAppearance = [UIBarButtonItem appearance];
[barButtonAppearance setTintColor:[UIColor blackColor]];

I'd be fine with changing the background color as an alternative.

Hi
How to customize selected row ?
Maybe this feature not exists , can you add ?
Thank you

Hi Petr,

I don't know if it is a real issue or perhaps i'm doing something wrong, but I was not able to integrate this cocoapod with my swift project. Basically after you install a pod to the project and add reference to the bridge header of the project, it fails to compile on all the UI (eg. UIView) class references inside .h files within a pod, complaining that it is unknown type. Do you know what could cause such a behavior, is it a bug in podspec? It there anything you can suggest for me to look at?

PS> I didn't find a place to post questions, so posting it as an issue which very well could turn not to be

Thanks,
Artem

First i was using a year or so the orginal project from Tim Cinel. Now because of iOS 8 i updated to your 3.0 project.

But, the simple sample didn't show up in my app. I discovered that the problem is with the parent View. The picker was added as a view to my rootViewController, which was not actually visible at that time, so the picker was bellow my current UIViewController and so the user was unable to see him.

I decided to implement a quick workaround in SWActionSheet.m changing the line 39 from:
_origin = (keyWindow.rootViewController ? keyWindow.rootViewController.view : keyWindow);

to:
_origin = keyWindow;

Now the picker shows up on all my devices and simulator. Tested on iOS 6, 7, 8 with iPad and iPhone.

I don't know if this workaround is good or bad but it works for me. Maybe should you fix this. Tim Cinel's code was working in my app, he added the picker to the containerView like that:
origin = (_containerView.superview ? _containerView.superview : _containerView);

P.S. Thank you for the code, its perfect backward compatible to iOS 6(thats what i need) and saved me a lot of time.

Regards,
Primoz

crash in
ActionSheetDistancePicker.m

line 120

if ([target respondsToSelector:action])
objc_msgSend(target, action, [NSNumber numberWithInteger:(NSInteger)bigUnits], [NSNumber numberWithInteger:(NSInteger)smallUnits], origin);

I have a Form Sheet with a button, when I press it the actionsheet toolbar buttons aren't visible although they do still respond to being pressed.

Here's the actionsheet:

This also happens with a page sheet but not full screen.

This didn't occur with the previous version I was using.

Steps to recreate:

1. Launch an ActionSheetDatePicker with UIDatePickerModeTime as mode and 10 minutes as interval. Do it at a time where the minutes is not divisible by 10, like 11:43.
2. Date picker should show a preselected time according to the minute interval, like 11:50, or 12:00, or 12:10. It is important that you do not change the value of the date picker.
3. Hit Done. Inspect the value of selectedDate on the doneBlock.

Expected result: selectedDate should return the preloaded value, like 11:50 or 12:00
Actual result: selectedDate has a value with the minutes similar to the phone's clock, like 11:53 or 12:03

Workaround:

- (void)clampDatePickerUsingMinuteInterval:(NSInteger)minuteInterval
{
    UIDatePicker *datePicker = (UIDatePicker *)self.pickerView;

    NSCalendar* calendar = [NSCalendar currentCalendar];
    NSDateComponents* components = [calendar components:(NSYearCalendarUnit | NSMonthCalendarUnit | NSDayCalendarUnit | NSHourCalendarUnit | NSMinuteCalendarUnit) fromDate:datePicker.date];
    NSInteger minutes = [components minute];

    NSInteger remainder = minutes % minuteInterval;
    if(remainder)
    {
        minutes -= remainder;
        [components setMinute:minutes];
        datePicker.date = [calendar dateFromComponents:components];
    }

}

So instead of getting the value from selectedDate, I get it from pickerView.date.

hello

i used DatePicker in ActionSheetPicket-3.0, but app crashed.

app crashed when i was selected am & pm in DatePicker

am & pm was selected completely, app is not crash

but am & pm wasn't selected completely, app is crash frequently.

When launching an ActionSheetPicker in landscape mode I get a "invalid context warning" in the console. Aside from the warning it seems to work OK.

The error reads something like the following

Jul 30 11:29:49 .... ActionSheetPicker[5133] : CGContextSetFillColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

I can get rid of the error by modifying the configureAndPresentActionSheetForView: method in AbstractActionSheetPicker.m to pass in an empty string instead of nil when creating the actionSheet

https://github.com/skywinder/ActionSheetPicker-3.0/blob/master/Pickers/AbstractActionSheetPicker.m#L424

From

_actionSheet = [[UIActionSheet alloc] initWithTitle:paddedSheetTitle delegate:nil cancelButtonTitle:nil destructiveButtonTitle:nil otherButtonTitles:nil];

To

_actionSheet = [[UIActionSheet alloc] initWithTitle:paddedSheetTitle delegate:nil cancelButtonTitle:@"" destructiveButtonTitle:nil otherButtonTitles:nil];

However while the context error goes away the picker isn't displayed correctly.

The error only seems to be on iOS 7. You can test this by running the example project and switching to landscape mode.

Whenever the done completion block runs, the VC pops back to the initial VC. I am sure this is not related to my code as i tested it. I will try to give it a look. Can you check this too, please ?

Thank you,
Sebastian

If a user taps outside the picker, they are still cancelling it. The ability for cancel blocks to run when the picker is hidden without using the cancel button is needed.

Hello
Anybody else experience lag when the ActionSheetPicker opens and closes? I'm using it on IOS 7.1

I'm having a hard time getting a custom cancel button and target-action to work with a datePicker. I just added setCancelButton to the example project below:

ActionSheetDatePicker *datePicker = [[ActionSheetDatePicker alloc] initWithTitle:@"Select a time" datePickerMode:UIDatePickerModeTime selectedDate:self.selectedTime target:self action:@selector(timeWasSelected:element:) origin:sender];

[datePicker setCancelButton:[[UIBarButtonItem alloc] initWithTitle:@"Not sure"  style:UIBarButtonItemStylePlain target:self action:@selector(datePickerCancelled:) ]];

datePicker.minuteInterval = minuteInterval;

[datePicker showActionSheetPicker];

It would be great if this library allows the control of which location the popup will appear relative to the origin. Right now the permittedarrowdirections is set to Any.

When using ActionSheetStringPicker.showPickerWithTitle along with doneBlock, I am hitting an error:

Missing argument for parameter 'cancelAction' in call

I used code below, but by donebutton text color is still white.. Whatever I tried, couldnt changed done button color from white to another color.. Problem exitsts on both ios8 and ios7..

    ActionSheetDatePicker* actionSheetPicker = [[ActionSheetDatePicker alloc] initWithTitle:@"" datePickerMode:UIDatePickerModeDate selectedDate:self.selectedDate target:self action:nil origin:textField];
    UIBarButtonItem* doneButton = [[UIBarButtonItem alloc] initWithTitle:@"Tamam4234" style:UIBarButtonItemStyleBordered target:nil action:nil];

    [doneButton setTintColor:G_BLACK];
    [actionSheetPicker setDoneButton:doneButton];

    [actionSheetPicker addCustomButtonWithTitle:@"Today" value:[NSDate date]];
    actionSheetPicker.hideCancel = YES;
    [actionSheetPicker showActionSheetPicker];

Thanks for a great control!

I'm not able to show the picker from a view that has been presented modally:

ProfileTableViewController *profileViewController = [[ProfileTableViewController alloc] initWithStyle:UITableViewStyleGrouped];
UINavigationController *navigationController = [[UINavigationController alloc] initWithRootViewController:profileViewController];

[self presentViewController:navigationController animated:YES completion:^{}];

After profileViewController is in the forefront of the screen, whenever I try to show an ActionSheetPicker, it shows itself behind the profileViewController view (that was presented modally with the code above).

This is how I show the ActionSheetPicker:

                ActionSheetDatePicker *datePicker = [[ActionSheetDatePicker alloc] initWithTitle:@"Select Date of Birth" datePickerMode:UIDatePickerModeDate selectedDate:[NSDate date] target:self action:@selector(dateWasSelected:element:) origin:[self.tableView cellForRowAtIndexPath:indexPath] cancelAction:@selector(datePickerCancelled)];
                [datePicker setCancelButton:[[UIBarButtonItem alloc] initWithTitle:@"Cancel"  style:UIBarButtonItemStylePlain target:self action:@selector(datePickerCancelled)]];

                [datePicker showActionSheetPicker];

when i user ActionSheetDatePicker in the uinavigationcontroller. It does work. After i have pressed the done button , the self.navigationcontroller = nil.

Has anyone noticed that the Actionsheet pickers don't show up at all on Xcode 6.0b2? I like Xcode 6 better than 5, but if I compile (even to IOS7) I'm getting a little blank box at the bottom of the screen.

Any Ideas?

It seems like iOS8 need a preferredSize for the content view controller of the popover, otherwise it will look like the one in the attachment.

I've fixed this issue in my fork by adding viewController.preferredContentSize = CGSizeMake(320, 260); in - (void)configureAndPresentPopoverForView:(UIView *)aView

The same code works on ios8 iphone 5 but doesn`t work on iphone 6 ( begins but it hides automatically).
iphone 5:http://youtu.be/DEKviPhG-Ds
iphone 6: http://youtu.be/tTsTJuUW7lY

the code is:

ActionStringDoneBlock done = ^(ActionSheetStringPicker *picker, NSInteger selectedIndex, id selectedValue) {

    citaaux=xmlhorasparser.horas[selectedIndex];
    [btHora setTitle:citaaux.m_hora forState:UIControlStateNormal];



};
ActionStringCancelBlock cancel = ^(ActionSheetStringPicker *picker) {

};
[ActionSheetStringPicker showPickerWithTitle:@"" rows:xmlhorasparser.horastexto initialSelection:0 doneBlock:done cancelBlock:cancel origin:btHora];

Compatibility issues still exists after forking project. Just putting this here for tracking purposes.

How can i change done button name?

And how can i access default buttons?

i found a weird issue, after upgraded to actionsheetpicker 3.0, everything is fine on iOS6, iOS7 and iOS8. Every parameter is fine and it was perfectly working fine with pervious version of ActionSheetPicker. however, with 3.0 on iOS5.1.1, i used it on three places（ActionSheetStringPicker）, two places of three pickers i used will crash when i click no matter done or cancel in the action sheet. without any error or warning, and further, i couldn't enter the page with that picker anymore until i restart the app(still without any warning). any idea?

Feature request, please add a delegate that is called on a custom button being clicked.
The delegate can be called with or without the need to value in the picker.

When project running on iPad with Swift implementation - popover not appeared.
Reproducible in project example.

How can we set a date range or rather a upper limit of date available in ActionSheetDatePicker ?

Like I am using it in date of birth field and right now it doesnt have any upper limit and shows future dates as well, what I want however is it to show maximum till today's date

I think you want:

if (self.initialSelections.count > 0)

instead of:

if (self.initialSelections)

or only initialize the array in the initWithTitle method if intialSelections is not nill:

    if(initialSelections != nil)
    {
       self.initialSelections = [[NSArray alloc] initWithArray:initialSelections];
    }

Hi there,

I have problems to run your samples. I pulled your ActionSheetPicker project and opened Example.xcworkspace with XCode 6.1 beta (6A1030). Right after that I see compile errors:

/tmp/ActionSheetPicker-3.0-master/Pickers/DistancePickerView.m:176:31: No visible @interface for 'DistancePickerView' declares the selector 'insertSubview:atIndex:'

The referenced line is:

[self insertSubview:label atIndex:0];

Do you have an idea what I'm doing wrong?

Regards, Leif

This is not an issue, but a question.

What is the preferred way to include ActionSheetPicker in a project? I've tried to include the CoreActionSheetPicker framework in my project but ld fails with the following error when I try to compile for the simulator:

ld: warning: ignoring file /Users/mts/Development/Projects/AmortizationV2/CoreActionSheetPicker.framework/CoreActionSheetPicker, missing required architecture x86_64 in file /Users/mts/Development/Projects/AmortizationV2/CoreActionSheetPicker.framework/CoreActionSheetPicker (3 slices)

I tried building CoreActionSheetPicker framework with different architecture settings without success.
Any tips?

Thanks,
Martin

I tried to use the ActionSheetDatePicker in CountDownTimer mode.

// let selectedDate = NSDate(timeIntervalSince1970: NSTimeInterval(600))
let selectedDate = NSDate(timeIntervalSinceReferenceDate:  NSTimeInterval(600))
var datePicker = ActionSheetDatePicker(title: "Time Interval", datePickerMode: UIDatePickerMode.CountDownTimer, selectedDate: selectedDate, target: self, action: "datePicked:", origin: self.view)

datePicker.minuteInterval = 10
datePicker.showActionSheetPicker()

I would expect the DatePicker to be preset at 0h and 10min but it is preset at 1h 10min

More important I assume the function datePicked is called by ActionSheetDatePicker with a NSNumber instead of a NSDate. The number / date is most of the time 60, regardless of the selection I make in the picker.

Hi,

I've been looking around and I did some tests it doesn't seems possible to me that we can use selectRow(row: Int, inComponent component: Int, animated: Bool) like for the default UIPickerView.

Can you add a method to do so please?

I followed the code in your example to implement a time picker and here is my code:

-(void)selectATime:(id)sender {
    NSInteger minuteInterval = 5;
    NSInteger referenceTimeInterval = (NSInteger)[self.selectedTime timeIntervalSinceReferenceDate];
    NSInteger remainingSeconds = referenceTimeInterval % (minuteInterval * 60);
    NSInteger timeRoundedToFiveMinutes = referenceTimeInterval - remainingSeconds;
    if (remainingSeconds > ((minuteInterval * 60) / 2)) {
        timeRoundedToFiveMinutes = referenceTimeInterval + ((minuteInterval * 60) - remainingSeconds);
    }
    self.selectedTime = [NSDate dateWithTimeIntervalSinceReferenceDate:(NSTimeInterval)timeRoundedToFiveMinutes];

    ActionSheetDatePicker *datePicker = [[ActionSheetDatePicker alloc] initWithTitle:@"Select a time" datePickerMode:UIDatePickerModeTime selectedDate:self.selectedTime target:self action:@selector(timeWasSelected:element:) origin:sender];
    datePicker.minuteInterval = minuteInterval;
    [datePicker showActionSheetPicker];
}

-(void)timeWasSelected:(NSDate *)selectedTime element:(id)element {
    self.selectedTime = selectedTime;
    NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init];
    [dateFormatter setDateFormat:@"h:mm a"];
    self.timeLabel.text = [dateFormatter stringFromDate:selectedTime];
    [self.timeLabel sizeToFit];
    NSLog(@"%@", self.selectedTime);
}

Using the selector, I pick 4:00 AM and the label that I have successfully shows 4:00 AM, however, when I log self.selectedTime or selectedTime within timeWasSelected, the time outputted is 4 hours greater than it should be. For 4:00 AM, I get this printout: 2014-10-08 08:00:00 +0000. Clearly 8 AM /= 4 AM

Receiving following error in iOS7

ActionSheetPicker-3.0/ActionSheetStringPicker.h:31:15: Typedef redefinition with different types ('void (^)(ActionSheetStringPicker *__strong, NSInteger, __strong id)' vs 'void (^)(ExpireMonthYearActionSheetPicker *__strong, NSString *__strong, NSString *__strong)')

with using your example code :

    NSArray *colors = [NSArray arrayWithObjects:@"Red", @"Green", @"Blue", @"Orange", nil];

    [ActionSheetStringPicker showPickerWithTitle:@"Select a Color"
                                            rows:colors
                                initialSelection:0
                                       doneBlock:nil
                                     cancelBlock:nil
                                          origin:self];