skyrockettoys / ardupilot Goto Github PK

Issue details

I'm unable to update the repository submodules.

Version

skyviper-latest (95ba9ed)
skyviper-stable (ca3364c)

Platform

[ X ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover

Airframe type

N/A

Hardware type

N/A

Logs

git log -1 --pretty=oneline
95ba9ed (HEAD -> skyviper-latest, skyrocket/skyviper-latest) AP_Declination: added generation of field tables

git submodule update --init --recursive
error: Server does not allow request for unadvertised object 574dfe9e2d947e3d5d7acd50033b56798a14fc1f
Fetched in submodule path 'modules/PX4NuttX', but it did not contain 574dfe9e2d947e3d5d7acd50033b56798a14fc1f. Direct fetching of that commit failed.

git config submodule.modules/PX4NuttX.url
git://github.com/ArduPilot/PX4NuttX.git

The F4Light HAL licensed files and references need to be removed from skyviper2018 branches
ArduPilot/ardupilot#8603

When reading this, it is hard to understand what the user_land variable means. At first glance it sounds like the user is attempting to land it manually. But that isn't the case. user_land is an alternative mode to LAND mode and is triggered when FLOW_HOLD is on prior to pressing the Land button. In this case, instead of using the AP built in LAND mode, the toy_mode code has a "new mode" which lands the craft while still using the FLOW_HOLD mode to maintain position. Obviously, in the future the goal should be to have an official FLOW_HOLD mode, or even just to put the use FLOW_Hold logic directly in the Land mode. But, in the short term, consider changing the name of this variable so the code is easier to understand.

Issue details

The Skyviper quads have the bad habit of burning out motors if a prop gets tangled or caught. The problem is that the copter (whether is auto or manual) doesn't have a function to make the copter completely turn off the motors. So if you have a bad landing in high grass, the props will get tangled, but the motors will still run for a few (10-15) seconds which can cause them to burn out. Recommend programming an emergency shut-off function then linking that to a button combo on the controllers.

Version

v2450HD (latest firmware)

Platform

[ ] All
[ ] AntennaTracker
[X ] Copter
[ ] Plane
[ ] Rover

Airframe type

quadcopter

Hardware type

?

Logs

Please provide a link to any relevant logs that show the issue

This can cause printf (i assume this is the eventual destination of these calls) to buffer overflow.

In my own experience with the 2450, when the motors "start to go bad" the thrust needed to keep them in the air changes dramatically. While it is good that land_throttle can be adjusted, only using land_throttle to decide how must thrust to give may be problematic when these motors start to fail. While you can't prevent motors from failing, it also may not be good PR for the SkyRocket brand that after 2 months of flying my SV smacks into the earth everytime I click the Land button.