skyfloogle / gm8x_fix Goto Github PK

If you call get_function_address() with the name of a function from a dynamic library included by a GEX extension or a script (including ones from extensions), then at best, 0 or a garbage value may be returned, and at worst, an Access Violation error may occur.

The preferred fix for the get_function_address() is to simply return -1 in these cases, as it does for non-existent names.

At the moment, the patch does not do this, since it is assumed that GM will never be loaded to an address other than the base one. However, for the accuracy of the patch, this should still be done.

It should be also checked whether the current fixups overwrite the patched code on runner loading.

It would be nice to have option to remove names of broken functions from the lookup table to make game literally uncompilable if it uses them. This will help not only to debug them but also to show much more production-ready error messages, especially in case of dynamic code execution (execute_string() etc).

For example, with DirectPlay patch it will remove mplay_* functions, and with scheduler patch it will remove functions that depend on the changed DLL import. Maybe it also should remove joystick_* functions as well with joystick patch.

Please note that for Delphi strings it's not enough to set first string byte to '\0', but the Pascal string header should be edited too. Or, if they're being added at run-time on initialization, we could just NOP these calls.

As it turned out (cher-nov/gm8_compat#2 (comment)), 218 is almost nearly identical to 141, but also features some useful math functions and full support for 820 gmk format comparing to 141 (not only in game settings block but also in room and object ones).