skydoves / androidribbon Goto Github PK

Hi sir, I am using your library and its awesome. Currently I am facing issue with RibbonView Drawable tint is not working with SVG.

<com.skydoves.androidribbon.RibbonView android:id="@+id/rbView" android:layout_width="wrap_content" android:layout_height="@dimen/_33sdp" android:text="Active" android:textColor="@color/white" android:textSize="@dimen/_10ssp" app:ribbon_rotation="40" android:fontFamily="@font/montserrat_medium" app:ribbon_drawable="@drawable/ic_ban_horizontal" app:ribbon_ribbonRadius="@dimen/_4sdp" app:drawableTint="@color/colorBlue" />

        here us the code that I am using.

• Library-Version [1.0.2]

Describe the Bug:

My Layout having CoordinatorLayout -> (In Top) AppBarLayout-> CollapsingToolbarLayout-> MaterialToolbar-> ConstraintLayout-> AppCompatEditText and RecyclerView inside CoordinatorLayout. Used ShimmerRibbonView in the RecyclerView Item. Whenever the keyboard opens for AppCompatEditText, the ShimmerRibbonView is moves toward left

Expected Behavior:

ShimmerRibbonView should not move.

Is your feature request related to a problem?

A clear and concise description of what the problem is.

Describe the solution you'd like:

A clear and concise description of what you want to happen.

Describe alternatives you've considered:

A clear description of any alternative solutions you've considered.

Please complete the following information:

• 1.0.2
• Likely all, but tested on an Emulator with Android 11

Describe the Bug:

When using RibbonView in e.g. a RecyclerView, clicking on an item in the RecyclerView, and then returning to the RecyclerView after a few times the position of the ribbon will change.

The likely reason for this is a missing check in onLayout(changed: Boolean, ...) whether the layout actually did change. Only then the rotation code should be applied which also changes x/y values of the View.

I'll provide a PR with a fix.

Expected Behavior:

Postition of the ribbon always stays stable.

Hi,
I have used ShimmerRibbonView in recyclerview and the parent is constraint layout. In UI Editor and app deployed, view working good. But after navigating to a new Activity by clicking on the card where ShimmerRibbonView is placed, returning back to the current activity view automatically positions itself down. If tried three times, each time view goes down to its height. I tried to fix it by placing it in a container with some width and height even though, view appears to be resizing itself. Adapter was not refreshed at that time onResume().