skybrud / skybrud.umbraco.search Goto Github PK

View Code? Open in Web Editor NEW

2.0 5.0 5.0 1.09 MB

License: MIT License

C# 99.75% Batchfile 0.25%

skybrud limbo umbraco uimbraco-package umbraco-packages umbraco-v7 umbraco-v8 search examine dotnet

skybrud.umbraco.search's People

Contributors

Stargazers

Watchers

Forkers

jtone123 nikcio appletv850

skybrud.umbraco.search's Issues

DisableHideFromSearch not working

Example

public VkNewsListOptions()
        {
            ContentTypes = new ContentTypeList { Constants.VkConstants.DocumentTypes.NewsPage };
            DisableHideFromSearch = false;
            RootIds = new int[] { Constants.VkConstants.Pages.NewsList };
            TextFields = new FieldList
            {
                new Field("nodeName_lci", 15),
                new Field("title_lci", 10),
                new Field("teaser_lci", 10)
            };
        }

Outputs:
hideFromSearch:0 (subjectArea_search:6e2715390e0a488791bfaf503d420c8e OR mntpLocations_search:33f2abd6a6b348978fb004362bef8edf OR mntpLocations_search:all OR mntpSubjects_search:all)

public VkNewsListOptions()
        {
            ContentTypes = new ContentTypeList { Constants.VkConstants.DocumentTypes.NewsPage };
            DisableHideFromSearch = true;
            RootIds = new int[] { Constants.VkConstants.Pages.NewsList };
            TextFields = new FieldList
            {
                new Field("nodeName_lci", 15),
                new Field("title_lci", 10),
                new Field("teaser_lci", 10)
            };
        }

Outputs:
hideFromSearch:0 (subjectArea_search:6e2715390e0a488791bfaf503d420c8e OR mntpLocations_search:33f2abd6a6b348978fb004362bef8edf OR mntpLocations_search:all OR mntpSubjects_search:all)

Bump Umbraco dependency so we can work with the block list

Should be 8.7.0 at minimum:

https://github.com/skybrud/Skybrud.Umbraco.Search/blob/v3/latest/src/Skybrud.Umbraco.Search/Skybrud.Umbraco.Search.csproj#L27

Debugger not working in v8

Example

Works:

VkNewsListOptions options = new VkNewsListOptions(Current.Logger)
            {
                Limit = limit,
                Offset = offset,
                Text = text,
                Location = locationUdi,
                Subject = subjectUdi
            };

Fails:

VkNewsListOptions options = new VkNewsListOptions(Current.Logger)
            {
                Limit = limit,
                Offset = offset,
                Text = text,
                Location = locationUdi,
                Subject = subjectUdi,
                IsDebug = true
            };

FormatException on GetSortValyeByDateTime

Ran into an issue where for some reason it seems the datetime string saved is not a valid datetime. It throws a format exception but it has no info on what it is trying to parse. Would it be possible to add a try catch block here with some helpful logging?

The error gotten is this:

{
    "Message": "An error has occurred.",
    "ExceptionMessage": "String was not recognized as a valid DateTime.",
    "ExceptionType": "System.FormatException",
    "StackTrace": "at System.DateTimeParse.ParseExact(String s, String format, DateTimeFormatInfo dtfi, DateTimeStyles style)
       at Skybrud.Umbraco.Search.SearchUtils.Sorting.GetSortValueByDateTime(ISearchResult result, String propertyAlias)"
}

It's this method: https://github.com/skybrud/Skybrud.Umbraco.Search/blob/v3/latest/src/Skybrud.Umbraco.Search/SearchUtils.Sorting.cs#L21-L30

Was thinking something along these lines could be super helpful in debugging it!

public static DateTime GetSortValueByDateTime(ISearchResult result, string propertyAlias) {

	string dateString = result.GetValues(propertyAlias)?.FirstOrDefault();
	
	if (!string.IsNullOrWhiteSpace(dateString)) {
		try {
			return DateTime.ParseExact(dateString, "MM/dd/yyyy HH:mm:ss", CultureInfo.InvariantCulture);
		} catch(Exception e){
			_logger.Error<SearchUtils>(ex, $"Error trying to convert to datetime for searchresult with id: {result.Id} and propertyAlias: {propertyAlias}")
		}
	} 

	string createdDate = result.GetValues("createDate")?.FirstOrDefault();
	return createdDate == null ? DateTime.MinValue : new DateTime(long.Parse(createdDate));

}

skybrud / skybrud.umbraco.search Goto Github PK

skybrud.umbraco.search's People

Contributors

Stargazers

Watchers

Forkers

skybrud.umbraco.search's Issues

DisableHideFromSearch not working

Example

Bump Umbraco dependency so we can work with the block list

Debugger not working in v8

FormatException on GetSortValyeByDateTime

Introduce helper class to aid indexing various content and data in Umbraco

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent