skrelpoid / betterrewardsmod Goto Github PK

CodeFactor found an issue: switch without "default" clause.

It's currently on:
main\java\skrelpoid\betterrewards\events\BetterRewardsInfoEvent.java:70

Idea for fix: Patch ProceedButton to behave like CancelButton on this screen.

If a relic purchase opens a screen, the close button may not appear. User has to click the map to escape the shop.
Witnessed with: Cauldron -> Dolly's Mirror

CodeFactor found an issue: switch without "default" clause.

It's currently on:
main\java\skrelpoid\betterrewards\events\BetterRewardsInfoEvent.java:72

Fix this by setting index of button to size of button list before adding.

Fixes potential issues with other mods that create a Button at Neow and issues if Neow Buttons change

probably will be a hack, but oh well

There is probably a start of run subscriber or something

CodeFactor found an issue: switch without "default" clause.

It's currently on:
main\java\skrelpoid\betterrewards\events\BetterRewardsInfoEvent.java:101

Copy available relics to new List. Remove boss relics with screens from copy. Shuffle or choose random from list. If result is null, return new Circlet.
Same for special relics.

Fixes issue that it lags when there are not many boss relics or special relics left

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.dungeons.AbstractDungeon.returnTrulyRandomColorlessCard()Lcom/megacrit/cardcrawl/cards/AbstractCard;
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:133)
Caused by: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.dungeons.AbstractDungeon.returnTrulyRandomColorlessCard()Lcom/megacrit/cardcrawl/cards/AbstractCard;
at skrelpoid.betterrewards.shop.LootboxShopItem.getForRoll(LootboxShopItem.java:164)
at skrelpoid.betterrewards.shop.LootboxShopItem.onPurchase(LootboxShopItem.java:83)
at skrelpoid.betterrewards.shop.AbstractShopItem.tryPurchase(AbstractShopItem.java:127)
at skrelpoid.betterrewards.shop.AbstractShopItem.update(AbstractShopItem.java:113)
at skrelpoid.betterrewards.BetterRewardsMod.updateShopItems(BetterRewardsMod.java:149)
at skrelpoid.betterrewards.patches.ShopScreenPatches$UpdateShopItems.Insert(ShopScreenPatches.java:26)
at com.megacrit.cardcrawl.shop.ShopScreen.update(ShopScreen.java:561)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2673)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:892)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:465)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)