The any2bool function does not appear to be covered by the list of dependencies.

The readme seems to imply that the defaults set in the jails class are used as default params on each of the jails::jail resources, but this is not so. The readme should make it clear when the defaults are used.

https://github.com/skoef/puppet-jails/blob/master/manifests/jail.pp#L112

The variable in the tempalte() function does not seem to exist.

    class { 'jails':
      defaults             => {
        'interface'        => $default_interface,
        'allow_mount'      => true,
        'exec_start'       => '/bin/sh /etc/rc',
        'exec_stop'        => '/bin/sh /etc/rc.shutdown',
        'exec_clean'       => true,
        'mount_devfs'      => true,
        'mount.zfs'        => true,
        'enforce_statfs'   => 1,
        'path'             => '/jails/$name',
      }
    }

The above jails class does not seem to respect the path option here, which should default to its name. For example, the following line in jail.conf will allow wildcard jail roots.

path = "/jails/$name";

I think it would make life simpler to use concat to build up a single jail.conf file. Here are a couple benefits I see.

• The jail(8) command would work without specifying -f.
• Defaults could be set at the top of the jail.conf file to simplify jail configuration.

What do you think? Are you open to the idea?