skills / write-javascript-actions Goto Github PK

The new cloned repository seems not to be working

I have cloned the repo and refreshed the page several times but the repo is not updating and the readME file remains the same

I have done the steps below

1. Go to github skills
2. Click on javascript actions
3. Scroll down to Start course
4. Enter your new repository name
5. Click create repository
6. Refresh the repository
7. See error ,no New ReadME file as stated in the read me

Please include screenshots.

Additional context

Add any other context about the problem here.

Within Step 1 - Activity 1 - 9. it states "we will remove the need to upload node_modules in a later step", however this is never addressed.

Summary

I had to manually update the README to Step 2, since the workflow that updates such file is not working properly. Even when the instructions are reproduced in the same way

How to reproduce

Just do the same steps of the Step 1 from the template.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
I think the yml describing the full file after edits is incorrect
I used http://www.yamllint.com/ to check whether it lints as well

To Reproduce
Steps to reproduce the behavior:

1. Go to 'yaml lint'
2. Paste the following

- name: JS Actions

on:
  issues:
    types: [labeled]

jobs:
  action:
     runs-on: ubuntu-latest

     steps:
       - uses: actions/checkout@v3

     	 - name: ha-ha
         uses: ./.github/actions/joke-action

3. See errors (<unknown>): did not find expected '-' indicator while parsing a block collection at line 1 column 1
4. You can see a live example of this fails on my repo here - https://github.com/anujdeshpande/test-action/actions/runs/2660634776/workflow

Expected behavior
The yml should lint.

Screenshots

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
Redundant file content in section 4

To Reproduce
Go to section 4 of the readme, it contains the same file content twice. Once as description, once as activity

Expected behavior
To see the two bits merged

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Per docs style guide, we don't use the "-ing" form of verbs. Proposing to update course name to "Write JavaScript Actions".

Describe the bug
Step 6: Trigger the joke action will end up causing the error below

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node18' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)

https://github.com/nshun583/writing-javascript-actions/actions/runs/3308162573

To Reproduce
Steps to reproduce the behavior:

1. Start the course of writing-javascript-actions in CentOS Stream 9 environment (for example)
2. In Step 1: Initialize a new JavaScript project, install Node.js by following official document from dnf
3. Doing so will only give learners to the option to go with ver.18

$ LANG=C;sudo dnf module list nodejs
Last metadata expiration check: 1:01:07 ago on Mon Oct 24 02:53:19 2022.
CentOS Stream 9 - AppStream
Name                    Stream                  Profiles                                                  Summary                           
nodejs                  18 [e]                  common [d] [i], development, minimal, s2i                 Javascript runtime                

Hint: [d]efault, [e]nabled, [x]disabled, [i]nstalled

4. In later of the course, define ver.18 instead of 12 in .github/actions/joke-action/action.yml
   since it is the version can only be installed

runs:
  using: "node18"
  main: "main.js"

$ LANG=C;sudo dnf module install nodejs:12
Last metadata expiration check: 1:24:00 ago on Mon Oct 24 02:53:19 2022.
Error: Problems in request:
missing groups or modules: nodejs:12

5. When learners reached to Step 6: Trigger the joke action and Check the workflow results on the "Actions tab, they will face the error of

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node18' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)

Expected behavior
Since GitHub.Runner is still not supporting Node.js ver.18 as the environment variable,
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions
Don't forget to set up your workstation section in Step 1: Initialize a new JavaScript project
should notify learners not to install ver.18 and offer the way to intentionally install ver.12 or 16 with the alternative method

Screenshots
None

Device information
Any OS environment where the package management system (including the third-party one such as Homebrew in macOS) offers Node.js installation only of ver.18

Additional context
None

Implement custom action using JavaScript

Describe the bug

1. Workflow step state is non-0

   It appears that previous development on the template did not revert https://github.com/skills/writing-javascript-actions/blob/main/.github/script/STEP back to 0

2. Workflow conditional expressions improperly terminated

   The conditional expressions used to selectively trigger workflows in this skills course appear to have syntax errors. The following list of workflows use multi-line conditionals that are terminated improperly:

   • writing-javascript-actions/.github/workflows/4-create-javascript-files-for-action.yml

     -41-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :42:      && needs.get_current_step.outputs.current_step == 4 }}

   • writing-javascript-actions/.github/workflows/5-add-action-to-workflow-file.yml

     -44-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :45:      && needs.get_current_step.outputs.current_step == 5 }}

   • writing-javascript-actions/.github/workflows/2-configure-your-action.yml

     -42-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :43:      && needs.get_current_step.outputs.current_step == 2 }}

   • writing-javascript-actions/.github/workflows/1-initialize-javascript-project.yml

     -43-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :44:      && needs.get_current_step.outputs.current_step == 1 }}

   • writing-javascript-actions/.github/workflows/3-create-metadata-file.yml

     -44-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :45:      && needs.get_current_step.outputs.current_step == 3 }}

   • writing-javascript-actions/.github/workflows/6-trigger-action.yml

     -44-    if: ${{ github.repository_owner != 'TBD-organization' }} 
     :45:      && needs.get_current_step.outputs.current_step == 6 }}

3. Invalid YAML for multi-line conditional

   Using all of the examples above, this is invalid syntax for block YAML use cases.

   Instead of:

         if: ${{ github.repository_owner != 'TBD-organization'
           && needs.get_current_step.outputs.current_step == 6 }}

   One of the following forms must be used:

   1. Single line

            if: ${{ github.repository_owner != 'TBD-organization' && needs.get_current_step.outputs.current_step == 6 }}

   2. Multi line block

            if: |
              ${{ github.repository_owner != 'TBD-organization'
                  && needs.get_current_step.outputs.current_step == 6 }}

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
Use of this skills course respected the state of the workflow step under execution without errors.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.